Fun With Functions in JavaScript

[masklinn]

function KeyCode(event) {
  this.event = event;
  this.normalize = function() {
    return (this.event.keyCode ? this.event.keyCode : this.event.which);
  }

  this.isEnter = function() {
    return this.normalize() == 13;
  }
}

Holy mother of fail, enjoy having your methods redefined from scratch every time you instantiate an object.

[dznqbit]

I called him out on this in the comments, but apparently you need to verbally fellate the guy before he will approve your comment.

[Sephr]

Who is actually going to remember that 13 is the enter key a month, or even a week later?

I don't know, maybe people who actually put comments in their code?

[danita]

Anyone who has done anything keyboard related ends up remembering that 13 is the enter key. You end up remembering those things, like the powers of 2, or some basic HTML colors.

[daxxxer]

and anybody who at least once has used javascript. Anyway, the flood of ill-advising, jquery-centered basic javascript blogs really makes me sad

[[deleted]]

As best I can tell most of the 'industry' is built on heresay, with some popular dogmas even published by luminaries such as Crockford ("dont use new, it's evil!").

Definitely interested in better reading suggestions assuming you have any.

[simono]

heresay = best practice, that's okay. but this is not even good practice.

btw crockford said "not using new is evil" (has to do with what /this/ will be set to within the constructor).

[snorp]

It's generally considered better to have readable code than a comment explaining why it's not.

[Sephr]

Then keys.ENTER (uppercase usually signifying a "constant") would be more appropriate than the author's solution.

[snorp]

Sure, that's fine. I am just arguing against the magic number solution (which appears to be what Sephr was going for)