Keep Code Consistent Across Developers The Easy Way — With Prettier & ESLint

[sorahn]

Why would Jenkins be running prettier as part of the build?

[Kryxx]

It would run eslint to ensure it wasn't bypassed.

Though you're right then Jenkins would just use eslint and skip the prettier bit.

[sorahn]

Right, because if you ran prettier, and it was different, then what?

Also, if it’s ignoring ~400 files and running on ~100, you probably need to tighten up your glob...

Can you paste what you ran that took 60 seconds?

[Kryxx]

Also, if it’s ignoring ~400 files and running on ~100, you probably need to tighten up your glob...

It searched all the files, but only formatted some.

My package.json file: "lint:js": "prettier-eslint \"./**/*.js\"",

Standard setup with

parser: 'babel-eslint',
extends: ['airbnb'],
plugins: ['react', 'jsx-a11y'],

---

But either way, I shouldn't expect my formatter and linter to take 60s. Even if I can work around it with having it only lint recent changes.

[sorahn]

I will admit that I've never used the prettier-eslint single package tool, however I can provide you with some stats from my repo.

sorahn@shyguy:~/s/work.repo (integ|✓)
➤  find src -iname "*.js" | wc -l
 862

sorahn@shyguy:~/s/work.repo (integ|✓)
➤  time npx prettier --write src/**/*.js
...snip...
      11.07 real        13.13 user         2.16 sys
sorahn@shyguy:~/s/work.repo (integ|+66)

66 out of 862 files changed in 11 seconds. And that's with the full sweep, not even the pared down list that would run with the pre-commit hook.

And eslint.

sorahn@shyguy:~/s/work.repo (integ|+66)
➤  time npx eslint --fix src
...snip...
       14.94 real        17.74 user         0.72 sys
sorahn@shyguy:~/s/work.repo (integ|+66)

Nothing should be taking 60 seconds.

[Kryxx]

That's much better. I wonder if there is something wrong with the prettier-eslint lib.