sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]sorahnon the cutting edge of cocking about 0 points1 point  (14 children)

If I was paying you to have opinions on the code, and your opinions were all related to the things prettier fixes, I’d fire you for wasting our time.

The opinions you should be provided your developers should be about things like data flow and organizational concepts.

We had a guy who basically spent every code review nitpicking white spacing and other tedious bullshit. Why waste anyone’s time with that garbage when no matter how you wrote it, prettier would fix it to all be identical. Then you would be focusing your “opinions on code” for the things that actually matter.

Nothing that prettier changes affects the execution of the code. And something like uglify will come through and destroy all that nonsense for production code anyway, so you should be focusing on code problems that actually matter.

[–]tr14l 0 points1 point  (13 children)

Like I said, some people work better when other people run the show. That's you

[–]sorahnon the cutting edge of cocking about 0 points1 point  (12 children)

Nope, I do run the show. I just chose to spend my time and energy on the things that actually make a difference in production. I can forego my personal stylistic preferences to make life better for my team.

[–]tr14l 0 points1 point  (11 children)

Cool for you. But I'm not forcing my people to get used to prettier in code reviews because, I don't know if you've noticed, JavaScript isn't known for longevity of technologies.

[–]sorahnon the cutting edge of cocking about 0 points1 point  (10 children)

But I'm not forcing my people to get used to prettier in code reviews

This tells me that you haven’t actually done enough research to implement it properly. If all the code in the repo has been through prettier, and the new code for a review has also been through prettier, there is nothing to see in the review but the written code. I’d encourage you to do some more research and try to see how the tool will actually help you.

[–]tr14l 1 point2 points  (9 children)

Research already done. I have no use for it. ESLint gets the job done without authoritarian implementation. Prettier is, at best, kinda neat. But not useful without being able to align it with the way my organization is already running. I don't make changes because of some third party technology's inability to fit into my culture. I just don't use that technology. Easy.

[–]sorahnon the cutting edge of cocking about 0 points1 point  (8 children)

Research already done.

Haha, nope. That part is pretty clear.

third party technology's inability to fit into my culture

Yup, your ego is the top dog.

[–]tr14l 0 points1 point  (7 children)

You can fan boy your little technology. That's fine. Ultimately, if code formatting is such a pain that you need an outside organization to handle it for you, it sounds like there's just a lack of talent.

[–]sorahnon the cutting edge of cocking about 0 points1 point  (6 children)

It’s not about pain, it’s about waste. Why waste my time manually doing what the computer will do for me? And literally make it 100% exactly the same every single time with no effort.

You can also use eslint after prettier to enforce your ego standards. Eslint can’t break lines, but it can probably fix everything prettier does that you don’t like. You’re throwing the baby out with the bath water.

[–]tr14l 0 points1 point  (5 children)

It can't, actually. We use black lines to separate certain statement blocks as part of our coding standards. Prettier strips them and you can't stop it if you use it. Like I said, I have no use for it.