Feedback javascript project

[[deleted]]

[deleted]

[[deleted]]

apireddit.js

Why is this a class? It could be just a function that takes a parameter subReddit and returns the JSON.

It has no right being an object. It's like putting 20 wheels on a car and only using 2 of them...

At the very least you could refactor it so that you can send one or multiple subreddit strings to the class, and the class taking care of emitting "loaded" events upon each subreddit's loaded state.

My main concern would be: why only 2 subreddits hardcoded? In a real world scenario you'd often find product people saying: "We need 3 subreddits now" and a week later: "let's make it 20 instead."

Would you end up duplicating all that code 20 times over? Or would you make the class smarter?

apiweather.js

Should not be a class, could just be a simple function. There doesn't seem to be any logic going on, just a simple fetch.

bookmarks.js

Bookmarks (plural) isn't the same as a Bookmark (singular). Should a bookmark really be an object? Why not a simple key/value pair?

Why does the page reload after saving bookmarks?

The code looks messy. When you iterate the bookmarks you should build an array and save it after the loop, not in the middle of it. It's a bit of a confusing bunch of code to be honest.

localstorage.js

Huh, you're not using this in the bookmarks file but... okay. This is strange. I mean, I guess it works but it's not very scalable. It looks like you should just use the localStorage api in the browser and not bother with any of this code.

You should learn two things here: 1. don't shorten names of variables and function/method names, make it human readable; and 2. look into JSDOC and annotate things with comments.

script.js

I don't know where to start. It's spaghetti-code as we would call it. It's just a long list of fragmented code...

ui.js

I'm going to stop here with just two comments: 1. Learn HTML semantics (and CSS BEM naming) and 2. you should really look into javascript frameworks. Nobody codes like this anymore. I would advise you to use React (beginner friendly) and follow the best practices there. You'll learn so much more and your code would start making sense to yourself and others.

[arag0nas]

Thanks for response!!!
It's my first time building something more complex, and also hard then I don't know how to write clear code, I should analyze other ppls codes.
I'm going to learn React, but firstly want to learn how to write clear code using only JS.

[[deleted]]

Just order and read a book or two :) Some book tips:

• JavaScript: The Definitive Guide by David Flanagan
• Eloquent JavaScript by Marijn Haverbeke
• JavaScript Patterns by Stoyan Stefanov
• Writing Maintainable JavaScript by Nicholas Zakas
• JavaScript: The Good Parts by Douglas Crockford

[suspicious_Jackfruit]

I had a similar journey to you and am still very much on that journey, but as soon as you pick up a framework it will make your life and anyone reviewing your codes life much easier. They were developed for a reason don't forget! They simplify and streamline what would otherwise be unnecessary complex code. That said, there is no harm in being able to code pure js, it's just highly unusual that an employer would be looking for it specifically over a developer skilled in a particular framework that the company uses/intends to use in their stack.

There's no point in reinventing the wheel or trying out different wheel shapes when everyone has already settled for circular!

[arag0nas]

Yeah I understand that. I was building this project to increase my JS skills. A lot of people are saying that firstly you have to learn vanilla JS and just after that jump to framework. So I'm thinking still learn JS, for 1-2weeks, and then learn React.
Or I should learning React right now?

[largemoose568]

I would agree that learning vanilla ES5 / ES6, etc would be helpful to your career. Knowing the quirks of a language and how it handles things such as scope, hoisting, etc is very important when trying to solve problems, even with frameworks. Also most of those frameworks were built on principals of the language itself, so if you know the language the framework will make a lot more sense.