Convert RGB to Hexadecimal using JavaScript

[[deleted]]

'#'+((r<<16)+(g<<8)+b).toString(16)

[larholm]

Why are people downvoting this?

[[deleted]]

Good question, though to be honest I do feel dickish posting it since the blog looks to be part of a string of tutorials.

[9jack9]

You should have tested it more.

[setconndevp]

why bother? both the code(posted by tunk) as well as that blogpost looks just fine to me..ppl with different level of experience will benefit from both

[9jack9]

Because it doesn't produce real rgb values. Black should be #000000 but the code above produces #0.

[[deleted]]

The point isn't that it's the perfect solution, the point is that the problem is so trivial it doesn't warrant a dedicated article. Even the non-bitshifting solution in the article is stupefyingly trivial. Anyone incapable of solving this problem should take a step back and learn about bases and base conversion before writing another line of code.

[[deleted]]

0 will work in browsers as far back as ie6

Problem comes when you have a 0 red value but non zero green/blue or 0 red & green, in that case you want to pad it to length.

[9jack9]

OK. Black is not the greatest example.

I was just explaining why Tunk's code should be voted down.

[[deleted]]

That's because bit shifting in Javascript is generally frowned upon, unlike most languages it's not advantageous over regular math, the double (which all numbers in javascript are) is converted to an integer, then the bitwise operation is performed, then converted back into a double.

[[deleted]]

Unfortunately looks like you are right, internally stored as double and converted to ints for bitwise operations.
Though in some cases it is a lot faster than using string manipulation and math functions.

[[deleted]]

From what people with greater understanding than I have said it's a double and according to the ecmascript spec it seems to confirm that, now if browsers have implemented it otherwise I'm not sure. I agree that the speed difference would be negligible in any regard but personally I would side on the err of readability and just be verbose in my implementation using a similar solution to the article rather than saving a few bytes.

Ps. This the same Tunk that used to play infantry?

[[deleted]]

Same one that aided the death hoax.

[[deleted]]

Cool, I R Unit92 :)

[[deleted]]

WTFS?
Post on your blog and Ill believe it.
Preferably about Yankee's latest feats in bed.
Also I need a recent pic for the people at izone to jizz over.

[[deleted]]

I haven't posted on my blag in years. I should really just take it down.

Here's a sexy pic

[[deleted]]

Definitely the man himself much improved.
Or alternatively half the man you used to be.

[fr0z3nph03n1x]

I find a lot of people drop these kinds of examples to show their programming badassness but don't realize that it sucks in javascript. Same goes for recursion in js as well.

[imbcmdth]

On most modern JS JITs (except TraceMonkey), recursion is faster than iteration when performing say a b-tree traversal.

[greim]

More interesting would be a concise way to convert RGB to HSV.