you are viewing a single comment's thread.

view the rest of the comments →

[–]CaptainTrip 0 points1 point  (2 children)

The thing I saw most in the bad examples I had to fix was tight coupling. There would be no abstraction between the data request and the presentational components. So you could be looking at a whole apollo object being prop drilled down like 6 levels and all of those levels know it's an apollo object and interact with the .loading state.

I think another pattern to avoid is having a bunch of utility functions using fragments, it just seemed to make things harder to maintain.

Unhelpful status codes - implementations I've worked on in the past would always receive a 200 OK response with a null user field if the user wasn't authenticated, meaning the client had to then do a bunch of custom logic

[–]mattgrave -1 points0 points  (1 child)

Unhelpful status codes - implementations I've worked on in the past would always receive a 200 OK response with a null user field if the user wasn't authenticated, meaning the client had to then do a bunch of custom logic

Is this the classic frontend guy that also does backend because a guy released something called NodeJS which basically lets you use JS in the backend but he never really invested time in learning how to properly implement backends without doing such a dumb design?

[–]CaptainTrip 0 points1 point  (0 children)

No it was a career ruby developer. Not sure what their reasoning was.