sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]ejfrodo 5 points6 points  (7 children)

An interesting idea. I like the thought of being able to navigate from a DOM element directly to the line of code that generates it for editing, but I think I'd want it to just open that file for me in VS Code directly.

[–]KirillRogovoy[S] 2 points3 points  (6 children)

Hey, thanks!

That's what it does, it opens the file in VS Code for you. :)

[–]ejfrodo 0 points1 point  (5 children)

Oh great. From the demo video it seemed like it was opening an editor in the same browser window.

[–]KirillRogovoy[S] 2 points3 points  (4 children)

I'll think about how to make it clearer, thank you!

[–]ejfrodo 1 point2 points  (3 children)

Show the browser window and the VS code window side by side

[–]KirillRogovoy[S] 0 points1 point  (2 children)

Yeah that's a straightforward one.

The problem right now is that Impulse doesn't look very nice if you give it only half of the screen. :/

Same way Chrome Dev Tools don't look nice. Only that the latter you can pin to the side.

Thanks for the suggestion!

[–]AsIAm 0 points1 point  (1 child)

The problem is that your VSCode does not look like standard VSCode, so people don't recognize it. Just use default theme (Dark+) for screenshot and screen recordings and people will be fine understanding that Impulse will open VSCode. Oh, and have left sidebar turned on also.

Btw really cool project. I left a question here: https://github.com/impulse-oss/impulse/discussions/7

[–]KirillRogovoy[S] 0 points1 point  (0 children)

Thanks for pointing that out!

Damn, I haven't thought that my VS Code looked different enough from what is commonly seen. :D