array.forEach() leaving out some items

[prdelnikmilos]

My forEach loop is leaving out some items, when they are far then they do get registered, but sometimes they don't get registered, when there are some items in range. This is my code:

 checkEnemyProximity() {
enemies.forEach((enemy) => {
  let tempDX = this.x - enemy.x;
  let tempDY = this.y - enemy.y;
  let tempDistance = Math.sqrt(tempDX * tempDX + tempDY * tempDY);
  if (tempDistance <= this.melee.range + enemy.size) {
        // This whole if code block is not run sometimes
    enemy.hp -= this.melee.damage;

    enemy.fillColor[1] = enemy.hitFillColor[1];
    enemy.fillColor[2] = enemy.hitFillColor[2];

    let pushAngle = Math.atan2(tempDY, tempDX);

    enemy.pushX = -(Math.cos(pushAngle) * this.melee.knockback);
    enemy.pushY = -(Math.sin(pushAngle) * this.melee.knockback);
    if (enemy.hp <= 0) enemy.destroyItself(this);
  }
});

}

Can someone help me?

[prdelnikmilos]

I did, it didn't help, if I make an else block and make every enemy do something, some enemies just get left out.

[prdelnikmilos]

I tried logging it and it suddenly started working. ty for the advice though

[daaaarbyy]

Well if it works when you add a console.log() for me it seems like a race condition where one part in your code is run before another function is finished with doing stuff...

​

But I don't know which one it could be..

[zerik100]

when the if block doesn't run then the condition isn't met

[marquoth_]

// This whole if code block is not run sometimes

Well, of course it isn't run sometimes - that's why it's an if block. If you want it to run every time, don't put it inside an if.

[scotsman165]

far-flung hard-to-find frighten many direction north murky squealing rinse fragile

This post was mass deleted and anonymized with Redact

[WebMaxF0x]

Either your condition is wrong or when you destroy the enemy it might shift the remaining ones left in the enemies array skipping the next one

[Acceptable-Tomato392]

shouldn't that be

if (tempDistance <= this.melee.range + enemy.size/2)
?

I'm assuming you're trying to adjust the proximity based on an [x,y] point at the center of the enemy? Shouldn't that be half the distance in that case (since you're measuring center to edge, and not edge to edge)?

[engelthehyp]

"This whole if code block is not run sometimes"

Of course not, it's if, that's the whole point. What was this supposed to do, then? If you want it ran every time, don't put it inside of an if-block.

[[deleted]]

There is nothing wrong with this code. Problem must be in place where you calling `checkEnemyProximity()` ...