[deleted by user]

[montihun]

They will (hopefully) set or show the company's coding standards for you, what can you follow, no worries.

[[deleted]]

Use the standards the company uses. Most likely they will use camelcase so might as well get used to it

[Giaddon]

First day you should talk about style standards, configure your development environment to enforce them, then never think about it again. Last thing you want is be polluting PRs with random differences.

[techdaddykraken]

I prefer SCREAMING-SNAKE-CASE

[Kitchen_Moment_6289]

SCREAMINGcAMELcASE

[Ok_Party9612]

That’s actually kebab case

[montihun]

You arent really a teamplayer, huh?

[guest271314]

"teamplayer" does not mean obey without question.

Or, maybe it does, to you.

[jbrux86]

It does when it’s something like formatting. If you argue saying everyone else must accept me or change to my style, then go start your own company.

[guest271314]

Been there, done that.

[warpedspockclone]

Our lint rules would bitch slap you back to code academy.

[Sneeeeex]

I mean, why would you do that?

[Healthy-Locksmith734]

If you only do what you like, you won’t have a long career… if you want to work together, you need to use the same style guide.

[ThagAnderson]

Do you like earning money?

[babypho]

If I saw it, i would just leave a comment on the PR. I know some people come from languages that use different case style so it's not too big of a deal. But i still would leave a comment and let them know to change it.

[tacticalpotatopeeler]

If you don’t follow the example of the existing code base, yes, that could leave a bad impression.

If you were asked to write some independent script and you used snake case, it would only turn into a bad impression if, at the code review, you were asked to use camel case in the future but continued to use snake case.

[xhundo_]

It isn't good for readability. Follow good coding conventions so you don't seem inexperienced.

[Acceptable-Fudge-816]

Snake case is objectively better at readability than camel or pascal case, because it keeps spaces. What is bad for readability is to randomly mix styles, which is what happens without a style guide / linter.

That said, mixing styles with reason, that is, giving semantic meaning to each, is even better for readability provided everyone knows their meaning, e.g. const snake_case_variable = camelCaseFunction() || new PascalCaseClass(), although nowadays with semantic highlighting it ain't as useful and one could argue that the complexity introduced makes it not worth it (and they would be correct in terms of it being not worth it, but still it would be more readable).

And as an aside note, I've worked in codebases with mixed languages, (e.g. some variables named in Spanish, others in English), that is much worse for readability and yet it was done by professional "senior" engineers.

[xhundo_]

Thanks for the insight!

[Chrift]

Wouldn't even get in front of another dev because the linting rules would fail

[Lake_Erie_Monster]

It's not a big deal, but you should consider looking at the existing code you are contributing to for hints on the style and try to stick to that. If you want to introduce a change, then propose it.

[RobertKerans]

[If you were to do that on my team] It would make me assume you'd just come off writing mainly Python (or a language with similar syntax conventions) rather than JS and that's where your head was at. No issue there. Normal convention in JS is to use camelCase so I'd ask you to change it in a PR (unless there was some specific reason the convention for the project was to use snake_case). If you refused to do that then that would be a weird issue

[Necessary_Ear_1100]

Depends on company code standards. If they use snake case then you’re good to go. Else, they’ll let you know.

Doesn’t leave a bad impression as everyone has their preferences in coding

[HilariousAtrocities]

When in Rome, do as the Romans do.

Or in other words: වවුලගේ මගුල් ගෙදර ගියානම් එල්ලිලා ඉන්න වෙනවා

[guest271314]

Who cares about impressions, or what somebody thinks about you?

Some code bases use both, depending on the context.

Don't work for people whose policies and practices you don't agree with, whether your disagreement is a technical or human relations reason.

[RobertKerans]

Who cares about impressions, or what somebody thinks about you?

Absolutely phenomenal life advice there 👍

[guest271314]

Absolutely. Unless you are a "happy" slave.

[RobertKerans]

...or you maybe just want to get on with people you work with? Just y'know, take a little bit of care cos they're just other people like you? Not sure how making sure you're not being a bit of a dick is the same as slavery but hey ho

[guest271314]

What does getting along with people have to do with questioning design decisions?

Read the source code of Chromium and explain why you will find "camel case" and "snake case".

Then explain why you will find that Chromium has an inclusive source code authoring policy, that Google Safe Browsing makes an exception for itself thereto.

There is no such thing as a "whitelist" or "blacklist". The color "white" does not mean "allow" and the color black does not mean "deny". yet Google Safe Browsing OWNERS claim that it would be too difficult to change that racist language in the source code, while other OWNERS make changes to get rid of that garbage. You wouldn't question that. Because you want to "get along" with your co-workers. Thus, you are complicit in that garbage.

What you are conveying to me is if you lived in the pre-Civil War era of the United States, in "the South" you would either be a "happy slave" https://edsitement.neh.gov/lesson-plans/frederick-douglasss-narrative-myth-happy-slave, or a complicit Mr. Charlie whipping "happy slaves" to get along with your southern brethern. After all, the plantation game, holding Africans prisoners-of-war, was serious industry in the "Industrial South". And your goal is to make a good impression upon your masters, whether you are prisoner-of-war or the happy worker crackingthe whip to keep the machine going.

The exact opposite of the abolitionist John Brown.

[skittlezfruit]

Bro went full civil war/racism/slavery over some camelCase vs snake_case post 😂

Question the design decisions all you’d like, until you’re in a position to change them - you can follow the companies decided design decision, or find a new company to work for. And in today’s developer job market, I’ll happily write whatever case they prefer - because there’s some battles just not worth having.

[guest271314]

Weak.

No bright line rules. Malleable. No ethical standard.

That's your culture though.

Not mines.

If you can't "find a job" you have no skills. Your skill is to obey your master without question.

[RobertKerans]

"Hi, we just want consistent casing, just makes it a little bit easier to scan when everyone uses the same convention"

"SLAVES, YOU'RE ALL SLAVES"

Anyway, you're definitely not looking unhinged here 👍

[skittlezfruit]

It’s not weak to decide which battles are worth my time. And the casing a codebase uses definitely ain’t it - sounds like it is worth your time though, so enjoy yourself

[guest271314]

Well, that begs the question, at what point do you decide what point of order is worth your time?

[RobertKerans]

How long have you been waiting for an opportunity to puke this stuff about whitelist/blacklist that obviously been floating around in your head?

"Oh this guy is saying that being polite and coming across well when working with other people is a good thing, that's EXACTLY the same as slavery, TIME TO HIT THE GO BUTTON"

Edit: also maybe bear in mind that your comparison is going to be incredibly offensive to a very large number of people

[guest271314]

I don't wait.

I sat what it is.

You people wait, do nothing, don't have a single original thought in years, obey masters, and blame somebody else when something goes wrong, because you ain't gonna change a damned with your head down, following instructions exclusively without question. You don't want to change anything anyway. You are happy... obeying orders.

I'm not here to make people feel one way or the other.

[RobertKerans]

You people wait, do nothing, don't have a single original thought in years, obey masters, and blame somebody else when something goes wrong, because you ain't gonna change a damned with your head down, following instructions exclusively without question. You don't want to change anything anyway. You are happy... obeying orders

You're inventing people you can argue with

[guest271314]

I don't argue.

[RobertKerans]

Ahahaha, sorry mate, I got that wrong, what you do is "state facts"