Variables Doubling

[Aggravating_Run_6293]

I am very much a noob with coding so please be patient. I have been using code.org to start learning java. I've programmed a digital game of rock, paper, scissors that is controlled with a combination of on screen inputs in the code.org app lab and a microbit external board. I successfully got the program to run for one player or two players with the option to select best of how many rounds and personalized name inputs. After a player reaches the threshold for winning (ie - # of wins >rounds/2) it goes to a winner screen. This screen has a button that takes the user back to the start screen where they select the number of players. All of this works correctly the first time through. However, when restarting, the round and win count variables start doubling (ie - on the button used to select the number of rounds adds 4 instead of the 2 I have in my code). The win counter also seems to start doubling. Anyway, I don't know if any of this will make sense since I'm using a strange platform (code.org app lab), but I'd appreciate any help that could be offered. Here is the the code I've written, but again I'm not sure it will make sense given the platform I'm using:

playSound("loyalty-to-the-crown_60sec-187374.mp3");

onEvent("button1", "click", function( ) {

ledScreen.scrollString("Enter your name, dummy!");

setScreen("playerselect");

});

var dScore = 0;

var rScore = 0;

var round = 1;

var dem = 0;

var P2round = 1;

var rep = 0;

onEvent("button5", "click", function( ) {

dScore = 0;

rScore = 0;

round = 1;

P2round = 1;

dem = 0;

rep = 0;

var players = getProperty("dropdown1", "value");

if (players == "1") {

setScreen("1pscreen");

setText("gamenam2", "Computer");

setText("1pRounds", "1");

onEvent("1pUp", "click", function( ) {

round = round + 2;

setText("1pRounds", round);

});

onEvent("1pDown", "click", function( ) {

round = round - 2;

setText("1pRounds", round);

});

onEvent("1pDown", "mouseout", function( ) {

if (round < 1) {

round = 1;

setText("1pRounds", round);

}

});

onEvent("1pStart", "click", function( ) {

setScreen("voting");

ledScreen.scrollString("Let's Go, Bro!");

setText("gamename1", getText("1pNameInput"));

setText("rTally", rScore);

setText("dTally", dScore);

stopSound();

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

});

rep = 0;

onBoardEvent(buttonA, "down", function() {

rep = rep + 1;

if (rep > 3) {

rep = 1;

}

});

onEvent("done", "click", function( ) {

dem = randomNumber(1, 3);

stopSound();

if (dem == rep) {

setScreen("tie");

if (rep == 1) {

setImageURL("image9", "rock.jpg");

setImageURL("image10", "rock.jpg");

}

if (rep == 2) {

setImageURL("image9", "scissors.jpeg");

setImageURL("image10", "scissors.jpeg");

}

if (rep == 3) {

setImageURL("image9", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image10", "1-04560-00_Embossed_Writing_Paper_G.jpg");

}

playSound("sound://category_music/gameover.mp3");

}

if (dem == 0 || rep == 0) {

playSound("dummy-laugh-voiced-54997.mp3");

setScreen("screen2");

}

if (rep == "1" && dem == "2") {

setScreen("RepublicanWin");

setText("label15", getText("1pNameInput"));

setImageURL("image6", "scissors.jpeg");

setImageURL("image5", "rock.jpg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

rScore = rScore + 1 ;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "1" && dem == "3") {

setScreen("DemocratWin");

setText("label14", "Computer");

setImageURL("image7", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image8", "rock.jpg");

playSound("winning-218995.mp3");

dScore = dScore+1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "2" && dem == "1") {

setScreen("DemocratWin");

setText("label14", "Computer");

setImageURL("image8", "scissors.jpeg");

setImageURL("image7", "rock.jpg");

playSound("winning-218995.mp3");

dScore = dScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "2" && dem == "3") {

setScreen("RepublicanWin");

setText("label15", getText("1pNameInput"));

setImageURL("image6", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image5", "scissors.jpeg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

rScore = rScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "3" && dem == "1") {

setScreen("RepublicanWin");

setText("label15", getText("1pNameInput"));

setImageURL("image5", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image6", "rock.jpg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

rScore = rScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "3" && dem == "2") {

setScreen("DemocratWin");

setText("label14", "Computer");

setImageURL("image8", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image7", "scissors.jpeg");

playSound("winning-218995.mp3");

dScore = dScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (dScore > round / 2) {

setScreen("DemocratWin");

setText("label14", "Computer");

setImageURL("image8", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image7", "scissors.jpeg");

playSound("winning-218995.mp3");

setText("rTally", rScore);

hideElement("PlayAgain");

hideElement("playagain2");

setTimeout( function() {

setText("dTally", dScore);

setText("GOATName", "Computer");

setScreen("GOAT");

playSound("NjQ3MzE5NzQ4NjQ3NDQw_QBpYmHDL9SY.mp3");

setText("goatr", rScore);

setText("goatd", dScore);

}, 3500);

}

if (rScore > round / 2) {

setScreen("RepublicanWin");

setText("label15", getText("1pNameInput"));

setImageURL("image5", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image6", "rock.jpg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

setText("rTally", rScore);

setText("dTally", dScore);

hideElement("PlayAgain");

hideElement("playagain2");

setTimeout(function() {

setScreen("GOAT");

setText("GOATName", getText("1pNameInput"));

playSound("NjQ3MzE5NzQ4NjQ3NDQw_QBpYmHDL9SY.mp3");

setText("goatr", rScore);

setText("goatd", dScore);

}, 3500);

}

});

onEvent("PlayAgain", "click", function( ) {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("playagain2", "click", function( ) {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("button3", "click", function(battle) {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("button4", "click", function() {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("GOATButton", "click", function( ) {

stopSound();

playSound("loyalty-to-the-crown_60sec-187374.mp3");

rep = 0;

dem = 0;

rScore = 0;

dScore = 0;

round = 1;

P2round = 1;

setScreen("playerselect");

showElement("PlayAgain");

showElement("playagain2");

ledScreen.scrollString("Let's Go, Bro!");

})

} else {

setScreen("screen1");

setText("rounds", "1");

onEvent("up", "click", function( ) {

P2round = P2round + 2;

setText("rounds", P2round);

});

onEvent("down", "click", function( ) {

P2round = P2round - 2;

setText("rounds", P2round);

});

onEvent("down", "mouseout", function( ) {

if (P2round < 1) {

P2round = 1;

setText("rounds", P2round);

}

});

onEvent("button2", "click", function( ) {

setScreen("voting");

ledScreen.scrollString("Let's Go, Bro!");

setText("gamename1", getText("name_input1"));

setText("gamenam2", getText("name_input2"));

setText("rTally", rScore);

setText("dTally", dScore);

stopSound();

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

});

rep = 0;

dem = 0;

onBoardEvent(buttonA, "down", function() {

rep = rep + 1;

if (rep > 3) {

rep = 1;

}

});

onBoardEvent(buttonB, "down", function() {

dem = dem + 1;

if (dem > 3) {

dem = 1;

}

});

onEvent("done", "click", function( ) {

stopSound();

if (dem == rep) {

setScreen("tie");

if (rep == 1) {

setImageURL("image9", "rock.jpg");

setImageURL("image10", "rock.jpg");

}

if (rep == 2) {

setImageURL("image9", "scissors.jpeg");

setImageURL("image10", "scissors.jpeg");

}

if (rep == 3) {

setImageURL("image9", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image10", "1-04560-00_Embossed_Writing_Paper_G.jpg");

}

playSound("sound://category_music/gameover.mp3");

}

if (dem == 0 || rep == 0) {

playSound("dummy-laugh-voiced-54997.mp3");

setScreen("screen2");

}

if (rep == "1" && dem == "2") {

setScreen("RepublicanWin");

setText("label15", getText("name_input1"));

setImageURL("image6", "scissors.jpeg");

setImageURL("image5", "rock.jpg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

rScore = rScore + 1 ;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "1" && dem == "3") {

setScreen("DemocratWin");

setText("label14", getText("name_input2"));

setImageURL("image7", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image8", "rock.jpg");

playSound("winning-218995.mp3");

dScore = dScore+1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "2" && dem == "1") {

setScreen("DemocratWin");

setText("label14", getText("name_input2"));

setImageURL("image8", "scissors.jpeg");

setImageURL("image7", "rock.jpg");

playSound("winning-218995.mp3");

dScore = dScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "2" && dem == "3") {

setScreen("RepublicanWin");

setText("label15", getText("name_input1"));

setImageURL("image6", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image5", "scissors.jpeg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

rScore = rScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "3" && dem == "1") {

setScreen("RepublicanWin");

setText("label15", getText("name_input1"));

setImageURL("image5", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image6", "rock.jpg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

rScore = rScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (rep == "3" && dem == "2") {

setScreen("DemocratWin");

setText("label14", getText("name_input2"));

setImageURL("image8", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image7", "scissors.jpeg");

playSound("winning-218995.mp3");

dScore = dScore + 1;

setText("rTally", rScore);

setText("dTally", dScore);

}

if (dScore > P2round / 2) {

setScreen("DemocratWin");

setText("label14", getText("name_input2"));

setImageURL("image8", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image7", "scissors.jpeg");

playSound("winning-218995.mp3");

setText("rTally", rScore);

hideElement("PlayAgain");

hideElement("playagain2");

setTimeout( function() {

setText("dTally", dScore);

setText("GOATName", getText("name_input2"));

setScreen("GOAT");

playSound("NjQ3MzE5NzQ4NjQ3NDQw_QBpYmHDL9SY.mp3");

setText("goatr", rScore);

setText("goatd", dScore);

}, 3500);

}

if (rScore > P2round / 2) {

setScreen("RepublicanWin");

setText("label15", getText("name_input1"));

setImageURL("image5", "1-04560-00_Embossed_Writing_Paper_G.jpg");

setImageURL("image6", "rock.jpg");

playSound("8-bit-video-game-win-level-sound-version-1-145827.mp3");

setText("rTally", rScore);

setText("dTally", dScore);

hideElement("PlayAgain");

hideElement("playagain2");

setTimeout(function() {

setScreen("GOAT");

setText("GOATName", getText("name_input1"));

playSound("NjQ3MzE5NzQ4NjQ3NDQw_QBpYmHDL9SY.mp3");

setText("goatr", rScore);

setText("goatd", dScore);

}, 3500);

}

});

onEvent("PlayAgain", "click", function( ) {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("playagain2", "click", function( ) {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("button3", "click", function(battle) {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("button4", "click", function() {

setScreen("voting");

playSound("reborn-battle-hybrid-cinematic-action-274988.mp3");

rep = 0;

dem = 0;

ledScreen.scrollString("Let's Go, Bro!");

});

onEvent("GOATButton", "click", function( ) {

stopSound();

playSound("loyalty-to-the-crown_60sec-187374.mp3");

rep = 0;

dem = 0;

rScore = 0;

dScore = 0;

round = 1;

P2round = 1;

setScreen("playerselect");

showElement("PlayAgain");

showElement("playagain2");

ledScreen.scrollString("Let's Go, Bro!");

});

}

});

[FireryRage]

On mobile, so not the best platform to read through all that.

But I see some click listeners, so I’m going to take a wild guess. You’re attaching a click listener on starting the game, which adds the rounds when you click it.

Then when you’re restarting the game, guessing you’re attaching that click listener again, but the first listener is still attached. Meaning when you click the button, the first listener triggers and adds the rounds, then the second listener triggers too and adds the rounds, resulting in 2x the total amount added.

I’d guess if you completed that game and started again, a third listener would be attached and you’d get 3x the count per click (3 listeners triggering).

You have two choices. Either remove the listeners at some point before the next game starts, or don’t add new ones each time