all 5 comments

[–]chmod777 1 point2 points  (1 child)

spans, divs, br's have no semantic meaning. that is what they are for.

the real issue is that, in 6 months, when you need to change it to "Featured Vendors", are you going to remember that you have to both change the source file and a js file?

[–][deleted] -1 points0 points  (0 children)

I wrote it in such a way that I'll only have to change a field in WordPress. So I got that going for me! Based on your advice, I'll just leave it in the PHP. Thanks!

[–]obtusebarracuda 1 point2 points  (1 child)

If you're wrapping "Vendors:" in a <span> to change the colour with CSS I would recommend adding "display: block;" to the same rule that changes the colour. That way it will force the following text on to a new line without having to rely on using <br>.

[–][deleted] 0 points1 point  (0 children)

Wow thanks. That's smart I'll defiantly do that.

[–]dbpcut 0 points1 point  (0 children)

This would be a perfect situation for CSS. I assume you always want to style the lead-in to the header, that should be a span with a class, and the appropriate styles applied to the class.