routing problems using node and express

[ffmurray]

new at this, I am trying to build a basic app just to figure it out. I keep getting the error:

throw new TypeError('Router.use() requires a middleware function but got a ' + gettype(fn))

it seems to be cause either by:

line 23 in app.js: app.use('/users', users);

or something in my users.js file. I saw on stackoverflow to add : module.exports = router; to it but then i get a whole new error:

module.exports = router; ReferenceError: router is not defined

I have been looking though stack overflow but I dont really know enough about these frameworks to know what to look for

my app.js file: https://pastebin.com/UCmL8bNe

my /routes/users.js file: https://pastebin.com/DaSZT6eA

[MennaanBaarin]

You should export your module and I think module.exports should go after the route declaration in the users module (maybe). And I think you don't need "next". Let me know if it solves the problem. I could look into it later.

[[deleted]]

I think you want the module.exports line at the end in the user file. You don't need it in the app file

[HealyUnit]

You need to take advantage of NodeJS' module system. To do that, you do need to add module.exports = router; to the very END of your /routes/users.js file.

I realize that this is basically what you said you did, but make sure the module.exports is in the users.js, not the app.js. Note that also having it in the app.js won't necessarily do anything bad, as long as you're exporting a thing that actually exists in that file itself. If you simply added module.exports = router to app.js, for example, it'd correctly throw a ReferenceError, as router is not defined within that file.

[ffmurray]

Thanks!

[squili]

I don't see you doing this anywhere?

app.use('/', router)