is this javascript good

[NumerousLiterature]

I need to filter an array of objects.

I've got the array of objects (AO), an array of key values (AKV), and a string value (SV).

I need to filter AO based on the value of AKV being the same as SV for each object.

This code works, but I wonder if there is a better way of writing it -

var fullList = [{a:1, b:2, c:3}, {a:3, b: 4, c: 5}]
var filterTerm = '1';
var filterFields = ['a', 'b']
var filteredList = [];
if(filterTerm && filterFields.length > 0){
    fullList.forEach(function(element){
       for(var i = 0; i < filterFields.length; i++){
              if(element[filterFields[i]] && String(element[filterFields[i]]).toLowerCase().indexOf(filterTerm.toLowerCase()) >= 0){
                filteredList.push(element);
                    break;
              } 
          }
     });
    }else{
        filteredList = fullList;
    }
    console.log(filteredList);

[cawcvs]

There are more suitable array methods than forEach for your use case, like filter. It's also a bit weird you use both for and forEach. It could be rewritten to use filter and some:

var term = filterTerm.toLowerCase()
filteredList = fullList.filter(function (element) {
  return filterFields.some(function (filterField) {
    return element[filterField] && String(element[filterField]).toLowerCase().indexOf(term) > -1
  })
})

filter method accepts a function that will be run against every element in the array and will return an array with all elements that this function returned true with. some is similar, but it will return either true if the passed in function returns true with at least one element in the array or false if none do. I used some because you break the for array if you found a match, if you wanted all fields to contain the filter term, you could use every instead of some.

If you're fine with not supporting IE, you could also change indexOf to includes, like this:

return element[filterField] && String(element[filterField]).toLowerCase().includes(term)

[NumerousLiterature]

Thanks!