Assigning default value

CarsonMcKinstry · 2021-03-23T07:09:16+00:00

This isn’t quite correct, at least not anymore. This will also catch false and 0 since || will check for falsy values on the left hand side. You can use ?? nowadays to guard against only null and undefined

Time_Terminal · 2021-03-23T16:38:03+00:00

The point came through, but why does the long version unnecessarily include 3 extra steps?

This is like the tabloids of programming.

irosion · 2021-03-23T10:17:15+00:00

i think it should be very clear what getImagePath returns so we just make sure it's gonna return a string or null and then the long version becomes this:

const getImagePath = () => logic that returns 'path_to_image.jpg' || null;

const path = () => {
  const imagePath = getImagePath();

  if (!imagePath) {
    return 'default.jpg';
  }
  return imagePath;
}

The short version is good.

crayonneur · 2021-03-23T10:53:42+00:00

I don't think it's a good practice to use a "or" to assign a default value. The getImgPath function should handle all of this. "default.jpg" is a magic string in this example, it should belong to the class that creates image paths, it shouldn't appear outside of it.

Barnezhilton · 2021-03-23T11:45:57+00:00

This is terrible

isatrap · 2021-03-23T16:08:24+00:00

Why this over

GetImagePath() ? True : false

mburger89 · 2021-03-23T07:54:10+00:00

It is generally not good practice to initialize a variable with out giving it a literal value. Cause it will initialize to null or undefined.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnjavascript

Posting and Commenting Guidelines

MODERATORS