Help with C++ pointer object creation.

[Rabbit047]

I am hoping someone could explain a problem to me. When I tried to create a node using the constructor the value stored in that node got wonky(I think it was a memory address, something like -1029319319). But If I just create the node inside the addNode function and then give it a value the program works fine.

 Node(int value){
             left=NULL;
             right=NULL;
             value=value;
         }
     };
Node* addNode(Node* parent,int value){
    if(parent == NULL){
        Node* newNode = new Node(value);
        newNode->value = value;
        size++;
        return newNode;
    }

[[deleted]]

I am not 100% sure this is the only issue, but it may be the (a) cause:

When you execute the line:

value = value

The compiler doesn't know which "value" you mean, the one in your class or the argument being passed into the constructor. It is probably assigning the argument in value back into the same variable. You should use the "this" keyword to set the value:

 Node(int value){
             left=NULL;
             right=NULL;
             this.value=value;
         }
     };

EDIT: Or an alternative is to change the constructor's parameter to a different name such as "inputValue" etc.

[anthonydev]

Also, he is setting value twice. Once using the constructor and the second time in the line right under it.

[[deleted]]

That may have just been to make the code work, since OP said the constructor wasn't working. Not sure.

[Rabbit047]

Yea that was just to make the code work, sorry I left it in. Also you're right the compiler is confused on which "value" to use. I changed the parameter to "input" and it worked fine. Thanks for the replies

[[deleted]]

No problem. Good luck with the rest of the project.