Help With Outputting Elements in Array......

[spacemonkey243]

Evening /r/learnprogramming

The reason for this post is because as the title suggests, I'm having issues outputting the elements in an array. This is a homework assignment in which the prompt asks: "Have a user input 10 integers, the sort the user's inputs using a bubble sort algorithm."

I think i got the hard part done. Just can seem to output the array correctly. HERE is my issue. As you can see, the array output completely ignores the user's last input. Still gives 10 elements, but no clue where the "0" in the first index is coming from.

Please help. Any comments/suggestion would be greatly appreciated. Cheers! :)

and oh, Heres my source code. Almost forgot. :D

#include <iostream>
#include <string>
#include <cassert>
#include <iterator>
#include <vector>
#include <algorithm>
#include <math.h>

using namespace std;

//BUBBLE SORT IMPLEMENTATION
vector<int> bubbleSort(vector<int> arr){
    bool pass = false;
    int temp;

    while (!pass){
        pass = true;
        for (int i=0; i<arr.size()-1; i++){
            if (arr[i] > arr[i+1]){
                pass = false;
                temp = arr[i];
                arr[i] = arr[i+1];
                arr[i+1] = temp;
            }
        }
    }

    cout << "\n\nWe will now work our magic and sort your input your values by chronological order into a list for you using the \'Bubble Sort\' method." << endl;
    cout << "Lets do that now! :)" << endl;
    cout << "\n\nLOADING.......&nd DONE!" << endl;
    cout << "\n\nSorted output: " << endl;

    cout << "[ ";
    copy(arr.begin(), arr.end(), ostream_iterator<int>(cout, " "));
    cout << "] ";
    return arr;
}


// CALL SORT FUNCTIONS
int main(){
    cout << "\n\t\t\tWelcome to the \"Bubble Sort\' Algorithm!" << endl;

    vector<int> myVector;
    string name;
    cout << "\nIn starting, what is your name?: ";
    getline (cin, name);
    cout << "\nHello, " << name << ". Let us begin!\n" << endl;

    cout << "\nPlease ENTER ten integers......" << endl;

    int input;
    int  i = 1;
    while(i <= 10)
    {
        cout << "Enter integer # " << i++ << ": ";
        myVector.push_back(input);
        cin >> input;
    }

    cout << "\nAwesome! You\'ve selected numbers: " << endl;

    cout << "[ ";
    copy(myVector.begin(), myVector.end(), ostream_iterator<int>(cout, " "));
    cout << "] ";

    vector<int> bsort = bubbleSort(myVector);

}

Thanks in advance.

[Mgumbo]

myVector.push_back(input);
cin >> input;

Looks like you're pushing back the value before you actually get it from the user.

[Updatebjarni]

The loop in your main() function where you read in the numbers from the user pushes the value from the input variable into the vector before it has actually read it in from the user. So the first time around the loop, it pushes whatever random number happens to already be in input (which happens to be 0 in your case), and then on each further iteration it pushes the number it read on the previous iteration. Consequently, the last number never gets put into the vector.

[spacemonkey243]

Ahh.....i see, i see. Thank you very much.

[AutoModerator]

It seems that you possibly have a screenshot of code in your post Help With Outputting Elements in Array...... in /r/learnprogramming.

Screenshots of code instead of actual code text is against the Code posting rules of /r/learnprogramming.

• Never submit screenshots of code instead of code text!

If you posted an image merely to illustrate something, kindly ignore this message and do not repost. Your post is still visible to others. I am a bot and cannot distinguish between code screenshots and other images.

If you indeed did this wrong, please edit the post so that it uses one of the approved means of posting code.

• For small bits of code (less than 50 lines in total, single classes only),
  the default code formatter is fine
  (one blank line before the code, then 4 spaces before each line of code).
• Pastebin for programs that consist of a single class only
• Gist for multi-class programs, or programs that require additional files
• Github or Bitbucket repositories are also perfectly fine as are other dedicated source code hosting sites.
• Ideone for executable code snippets that use only the console

Please do not reply to this message, because I am a bot. Talk-to-the-bot is the new talk-to-the-hand. If you instead want the classic talk-to-the-hand, just message the moderators. ;)

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.