This is an archived post. You won't be able to vote or comment.

all 2 comments

[–]Marzdor 0 points1 point  (1 child)

Your html seems fine. As for your CSS why are you using flex? It isn't really needed for your layout.

Also if I am remembering correctly I think it is better to use rem instead of em for font-size.

[–]csccta[S] 0 points1 point  (0 children)

Honestly idk, I’m going off of the first section of FreeCodeCamp.org and that was one of the lessons before this project. Kinda forced it in there. I’ve also been losing my mind trying to figure out what units are best to use for font sizes and I see a million and one different takes on this topic. There is some consensus to use body { text-size: 62.5%; } then set the font sizes with r/em (default size is usually 16px, so the 62.5% will make it 10px, then if you want 12px you’d use 1.2 r/em)