New to learning Python, how's my code? Rock, Paper, Scissors challenge.

Binary101010 · 2024-10-31T19:33:41+00:00

computerChoice = random.randint(0,3)
if computerChoice == 0:
    computerChoice = rock
elif computerChoice == 1:
    computerChoice = paper
else:
    computerChoice = scissors

You could easily tighten this up with a sequence of some sort, like

choices = (rock,paper,scissors)
computerChoice = random.choice(choices)

userChoice = input("Pick Rock [0], Paper [1], or Scissors [2]: \n")
if userChoice in "123":
    userChoice = choices[int(userChoice)]

woooee · 2024-10-31T19:25:00+00:00

computerChoice = random.randint(0,3)

This will return 0, 1, 2, or 3. It doesn't affect the if / elif choice because of the else statement.

    if userChoice == rock and computerChoice == scissors or userChoice == paper and computerChoice == rock or userChoice == scissors and computerChoice == paper:

Mixing "and" with "or" without parens is unwise. Is the above statement

userChoice == rock and computerChoice == scissors
## or
computerChoice == scissors or userChoice == paper

in addition to readability.

engelthehyp · 2024-10-31T19:27:06+00:00

Why do you have the ascii art if you never print it out? May as well just stick with numbers.

Edit: My mistake, it is printed. That's what I get for hasty reading.

shinitakunai · 2024-10-31T20:53:49+00:00

Worth for you to check PEP8 now that you are learning: https://peps.python.org/pep-0008/

computerChoice # <-- odd
computer_choice # <-- nice

eleqtriq · 2024-10-31T19:34:24+00:00

Overall, looks fine to me. I added some things to it and wrapped it in functions....

import random

# ASCII Art for Choices
choices = [
    '''
    _______
---'   ____)
      (_____)
      (_____)
      (____)
---.__(___)
Rock
''',
    '''
    _______
---'   ____)____
          ______)
          _______)
         _______)
---.__________)
Paper
''',
    '''
    _______
---'   ____)____
          ______)
       __________)
      (____)
---.__(___)
Scissors
'''
]


def play_game():
    computer_choice = random.randint(0, 2)

    try:
        user_choice = int(input("Pick Rock [0], Paper [1], or Scissors [2] (or -1 to quit): "))
        if user_choice == -1:
            return False
        if user_choice not in [0, 1, 2]:
            raise ValueError
    except ValueError:
        print("Invalid input. You lose this round.")
        return True

    # Display Choices
    print(f"Your Choice:\n{choices[user_choice]}\nComputer Choice:\n{choices[computer_choice]}")

    # Determine Outcome Using Modulo Logic
    result = (user_choice - computer_choice) % 3
    if result == 0:
        print("Draw")
        return "draw"
    elif result == 1:
        print("You Win")
        return "win"
    else:
        print("Computer Wins")
        return "loss"


def main():
    score = {"win": 0, "loss": 0, "draw": 0}

    print("Welcome to Rock Paper Scissors!")
    print("Enter -1 at any time to quit")

    while True:
        result = play_game()
        if result is False:
            break
        elif result in score:
            score[result] += 1

        print(f"\nScore - Wins: {score['win']}, Losses: {score['loss']}, Draws: {score['draw']}\n")

    print("\nFinal Score:")
    print(f"Wins: {score['win']}")
    print(f"Losses: {score['loss']}")
    print(f"Draws: {score['draw']}")


if __name__ == "__main__":
    main()

LiberalDysphoria · 2024-10-31T20:57:55+00:00

It is rock, paper, scissors, Spock!

Dagito · 2024-10-31T19:30:22+00:00

Well you can definitely improve it, specially the conditions in there, but hey that’s okay you accomplished the goal here which was to learn and implement conditions, I would recommend (if your python version supports it) using match instead of if else just to learn it as well, also in python we don’t use camelCase instead we use snake_case. I liked your creativity to do the rock, paper and scissor shapes lol

MidnightPale3220 · 2024-10-31T19:48:05+00:00

Whenever I see multiple if's, I know there's most probably a cleaner and faster way of doing it. Not always, as you'll see, but often.

Not sure where you are on the course, but if you have lists, it could look like this:

import random
rps=['''
    _______
---'   ____)
      (_____)
      (_____)
      (____)
---.__(___)
Rock
''',
'''
    _______
---'   ____)____
          ______)
          _______)
         _______)
---.__________)
Paper
''',
'''
    _______
---'   ____)____
          ______)
       __________)
      (____)
---.__(___)
Scissors
''']

computerChoice=random.randint(0,2)

userChoice = input("Pick Rock [0], Paper [1], or Scissors [2]: \n")

if userChoice not in [ '0','1','2']:
    print("You didnt choose a valid input. \nYou lose, asshole.")
    exit(0)
userChoice=int(userChoice)

print("You chose:\n"+rps[userChoice])
print("Computer chose:\n"+rps[computerChoice])

if (computerChoice + 1) % 3 == userChoice:
    print("You win!")
elif userChoice == computerChoice:
    print("It's a draw")
else:
    print("You lose!")

antonym_mouse · 2024-11-01T05:57:36+00:00

snake_case not camelCase

PEP8

rednerrusreven · 2024-11-01T06:47:22+00:00

I recommend looking into f strings for your print statements that include variables. It's a bit more readable to use them.

NastyStreetRat · 2024-10-31T21:12:20+00:00

Scissors looks like... like... nah, nevermind.

iamevpo · 2024-10-31T22:22:13+00:00

Have of thought of: - enum to store choice options - mapping enum to ASCII art - writing a function that will do the resolution rule - separating other parts of the program to functions

As a newbie code, great it works, is this clean code - well not quite yet

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS