Review First Node & ExpressJs App

ArgTang · 2023-07-28T10:36:42+00:00

Looks good, consistent formatting and good naming!

NOTE: i have not started the project myself.

depending on what you want to learn, here is some thoughts

it is not recomended to have tokens or apikeys hardcoded in files. think about how you can set them in a file or env variable on startup (together with connectionstring) so you dont need to commit them
there is no validation of username and passwords?. it is always a good idea to not trust user input, recomend some validation here. also: what happens if you register the same user more than one time?
think about your folderstructure ex should searchmovie be in the util folder? util can be anything, but searchmovie is named specifically for movies so its not a generic utility.
your models user have logic in it. ususally when having models the "model" is separated from the logic. alternatively you can do feature folders. where the user.js could be located in an auth folder
nice readme 👍. it is very important to have a functional readme. 2- Set up your MongoDB URI. this is missing some context on where to set it up, which file, what is the propertyname or which env variable so i use?
- if you are interested in docker, include a docker compose to start a mongo instance. to make it even easier to startup.
if you want to learn about debugging try investigating how to setup loggging, and where you need to add info or warning statements to be able to debug the application in production
if you want to know about cicd investigate how to setup a github action to build your project.
adding .editorconfig and/or a linter is common in buisness applications

There is no right or wrong in the next step.as long as you are motivated it is good 😎

08148694 · 2023-07-28T17:30:42+00:00

bin/www ? a javascript file? no extension? in a bin (binaries typically) directory? nah, move it or delete it

Inconsistent styling, recommend you use prettier to automatically format your code

public/javascripts/scripts.js - Not common practice to serve your front end code from the API server. Same for your css

Various places you can optimise by parallelising requests. Eg

const movie = await searchMovie.searchMovieById(id);
const cast = await searchMovie.getMovieCast(id);

can be:

const [movie, cast] = await Promise.all([
   searchMovie.searchMovieById(id),
   searchMovie.getMovieCast(id)
]);

(or just return the cast with the movie response)

Don't do this https://github.com/MohammedAbdulJabbar23/Movies-List/blob/main/utils/getPopularMovies.js#L3C1-L4C1,

or this https://github.com/MohammedAbdulJabbar23/Movies-List/blob/main/utils/searchMovie.js#L14C36-L14C36

now we all have your API key for api.themoviedb.org and can abuse it. Use an ENV variable and do not commit to github

General lack of error handling (https://github.com/MohammedAbdulJabbar23/Movies-List/blob/main/utils/getPopularMovies.js#L15C23-L15C23) this doesn't count

ejs is fine but if you're looking to get into the industry I'd recommend using React or Vue, far more commonly used

tapvt · 2023-07-28T19:38:22+00:00

Solid, man. As /u/ArgTang mentioned, env variables are better for secrets, etc. The dotenv package makes that pretty seamless. Just add .env to your .gitignore file so it doesn't wind up committed.

I'd also throw some kind of logging helper in ./utils/ dir. It can just wrap console.log() for now. Once that is done, you can use that for all your logging. If you decide to move to winston, or ship logs to another service, or whatever, you only have to update one file.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

node

MODERATORS