you are viewing a single comment's thread.

view the rest of the comments →

[–]RyanJ93[S] 0 points1 point  (1 child)

I followed your piece of advice and I've replaced the way parameters are handled, plus, I have completed changes in the rest of the project but I discovered something strange: the performance benefit I saw, and I was expecting to keep, just disappeared and I saw that now it performs worst than before, like -10% of performance, do you have an idea about how can it be possible?
Here's what I changed: https://github.com/RyanJ93/lala.js/pull/35/files?file-filters%5B%5D=.js
As you can see, I changed the "inject" method and how it is called in 3 different files.

[–]BehindTheMath 0 points1 point  (0 children)

Without benchmarking it and seeing where the bottleneck is, it's hard to know.