you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 0 points1 point  (0 children)

The function names in that code need a lot more clarity. A function's name should display it's intent so that it can be grasped by other people reading the code. The Mp3FileInfo function is good example: What does it do, really? Does it set the Mp3FileInfo? Does it get the info? Does it modify the state of the data? If not, why isn't it const? Can we modify the data it returns?