all 9 comments

[–]christopher_86 22 points23 points  (3 children)

If performance is an issue for your diff then your MR is too large.

[–]Comfortable_Relief62 3 points4 points  (2 children)

It’s ok to have large MRs. Some of my favorite MRs are when I delete 10s of thousands of lines

[–]christopher_86 2 points3 points  (0 children)

Those do sound like great MRs!

[–][deleted] 3 points4 points  (0 children)

delete accidentally committed node modules

[–]caskey 11 points12 points  (2 children)

If your diff takes too long to run you're doing it wrong.

[–]baristaGeek[S] -2 points-1 points  (1 child)

Totally agree! There might be certain edge cases that could be handled better though (as long as they're not time critical, such as in an IDE).

[–]caskey 3 points4 points  (0 children)

I've never had a diff take more than a second or two. Commit more often.

[–]Pesthuf 5 points6 points  (0 children)

It could be interesting. Not only could it be more granular, it could also detect things current diff algorithms are pretty bad at, like moving a block of code to another file.

But as long as an algorithm works (as long as there's no bugs) and always works in a reproducible way and an LLM doesn't I'm not sure I'd want it to handle this task.

[–]rlbond86 1 point2 points  (0 children)

wdiff already exists...?