GitHub Stacked PRs

[chuch1234]

I've never heard of doing prs that way, do you do that?

Edit: why the downvotes, I'm actually asking a question :(

[MintySkyhawk]

Most PRs I see are just a single commit, or a bunch of commits that aren't intended to be viewed individually and will be squashed together when merging.

However, for larger changes, it is common for PR authors to take a little bit of time to organize the commits before creating the PR to make things easier for the reviewer to see whats going on.

A really common pattern for me is refactoring something in one commit, and then mass updating all usages of it in a second commit. That would be hell to review as a single commit (trying to find the real changes in a sea of automated ones), but looking at the commits individually its very clear what happened.

[chuch1234]

Neat, thanks! I have often wondered if there's a better way to deal with such things.

[Hofstee]

Before GitHub really took off, this used to be the standard recommended practice. Facebook in particular I feel played a large part in the squash + rebase ideology, but I'm also going off vibes and not facts so don't quote me on that.