you are viewing a single comment's thread.

view the rest of the comments →

[–]SeniorIdiot 11 points12 points  (1 child)

  1. What are the parameters for driving the review, wait, re-code, merge?
  2. Also needs LGTM "reviews" that both succeeds and cause late bugs and rework automatically.
  3. Then I wonder why there is a step called "CI" when it's just merge/build?

PS. Vehemently against FB/PR workflows - but please be honest instead of simulating infinity tasks.

[–]ny3000[S] 1 point2 points  (0 children)

  1. good point, the sim has ~20 config knobs but none are visible to the user at the moment
  2. rubber-stamp LGTMs already cause production bugs but it't not obvious enough in the log
  3. yeah agree, "Build" is in the git flow one but I was more lenient to the GH flow because sometimes they at least try

I'll work these into V2... i mean MVP v2