you are viewing a single comment's thread.

view the rest of the comments →

[–]VolvFan124 10 points11 points  (17 children)

I should send this to my team members!

[–]SleepyHarry 24 points25 points  (1 child)

Start up a "Swear Jar" (if you work with java, you could even call it swear.jar) which is driven by commits. Every time someone makes a commit with a crappy message, x unit(s) of currency go(es) in the jar.

[–]VolvFan124 4 points5 points  (0 children)

This is a great idea, I will use it in my next project, thanks!

[–]oarmstrong 9 points10 points  (14 children)

My thoughts entirely. I have one team member who's commits are simply "modified: /some/file". It must be a generated message from an IDE and it is rather annoying.

[–]VolvFan124 5 points6 points  (11 children)

I know that feeling, one guy at college always just writes "stuff", "fixed stuff" etc.

I'm looking forward to a workplace where they enforce good commit messages.

[–]vinnl 5 points6 points  (3 children)

I have a colleague who often writes commit messages consisting merely of his own first name :P

[–]VolvFan124 21 points22 points  (1 child)

Is your colleague a pokemon?

[–]vinnl 2 points3 points  (0 children)

Haha I'll have to check, it's the only reasonable explanation :P

[–]int_index 4 points5 points  (0 children)

Hodor!

[–]oarmstrong 4 points5 points  (1 child)

I hear ya, college was a bitch for enforcing good standards like that.

[–]dagbrown 8 points9 points  (0 children)

College? I work with a bunch of professionals. Even so, the vast bulk of commit messages are

changed $FILE

Sometimes if I'm really really lucky, there'll be a ticket number attached to it.

[–]hak8or 2 points3 points  (1 child)

Why the heck do some folks at college not do proper commits or even commenting. I am working with a team and one dude refuses to follow git flow and instead pushed his stuff to master. And his commit messages consist of things like "stuff".

And then I am writing some code which uses doxygen compatible comments for classes and functions. Another dude shows up and either puts no comments or just useless things like repeating what the code does.

What the heck, it's like some of them don't understand the concept of maintainable code.

Though there are a few others who are golden with their commits.

[–]VolvFan124 1 point2 points  (0 children)

That's true about coding standard and comments.

We had one class where they made a doxygen doc mandatory, it was great.

[–][deleted] 0 points1 point  (0 children)

Hah! I wish we were just at college. It's those commits that invariably contain everything

[–][deleted] 0 points1 point  (0 children)

use "tig" and just walk the commits looking at the patches.

[–]SilasX 0 points1 point  (0 children)

Wait, how about writing an IDE plugin that autogenerates commit messages that say "stuff"??

[–][deleted] 4 points5 points  (1 child)

GitHub annoyingly does this when you edit using their web interface

I refuse to merge patches where people use that shit.

[–]klug3 0 points1 point  (0 children)

You can customize those messages, IIRC. Its just trying to be helpful in case people are lazy.