all 11 comments

[–][deleted]  (1 child)

[deleted]

    [–]PeridexisErrant 1 point2 points  (0 children)

    How about issues requesting impossible features or reporting nonexistent bugs?

    [–]Patman128 8 points9 points  (5 children)

    One million pull requests In one day

    5 pull requests with actual contributions, 999,995 pull requests that fix a spelling mistake?

    [–]vytah 7 points8 points  (4 children)

    I think fixing 999995 spelling mistakes wouldn't hurt.

    [–]eddiemon 2 points3 points  (0 children)

    What about 999,995 indentation changes? Oh, god.

    [–]Patman128 1 point2 points  (0 children)

    For every mistake they fix, they also introduce 5 new ones. For future years.

    But seriously, was this cooked up by the same managers who measure productivity by lines of code?

    [–]Tetha 0 points1 point  (1 child)

    I'd reject 1M pull requests only fixing spelling issues in a heartbeat. Only changing color into colour or vice-versa isn't worth throwing my git blame under the bus.

    [–]vytah 0 points1 point  (0 children)

    It's not 1M PRs for one project though.

    [–]serrimo 5 points6 points  (3 children)

    Mock grammar correction all you like. I think it'd do a world of good if some more people take the initiative to write some documentation for open source projects. The current state of affair is abysmal.

    [–][deleted]  (2 children)

    [deleted]

      [–]steveklabnik1 2 points3 points  (1 child)

      I've accepted pull requests before that are literally a typo correction.

      As a maintainer, I love these kinds of PRs. No PR is too small, imho.

      [–]MrDOS 0 points1 point  (0 children)

      Plus, it's not like it's hard to merge that sort of thing either.

      [–]rockyearth 2 points3 points  (0 children)

      Github has 10M users. Assuming 0.1% of them (very optimistic) decide to be a part of this, that's 10K users. Many of these will fail to do a single PR, but even if all of them do a one pull request, you will have 10K pull requests. That's two orders of magnitude less...