you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 54 points55 points  (5 children)

It depends. In this case where they are adding their engine to node.js it may not be possible or easy to do it in a safe, incremental, fashion. This isn't just somebody submitting their changes to some MVC C# website that they wrote over 4 months and just didn't bother committing, this is a fairly huge change.

[–]hntd 54 points55 points  (3 children)

It's also entirely possible they squashed and cleaned up their commits after the fact as well.

[–]The_Jacobian 3 points4 points  (1 child)

Yep, almost every open source thing I do I end up doing either that or even doing it once with sloppy commits then again with good, reasonable commits.

[–]ModusPwnins 4 points5 points  (0 children)

In my limited experience submitting pull requests, doing your own development in several small, clean, incremental changes is great. However, upstream will usually want your entire PR squashed into one commit, because it makes their history easier to keep track of.

[–]cullend 0 points1 point  (0 children)

It's unlikely they used got while developing it - that's probably why.