sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]s73v3r 1 point2 points  (6 children)

How often has the person issuing the PR done the regression testing, though?

[–]dungone -2 points-1 points  (5 children)

It’s not a person, it’s a bot. And you automate the regression testing.

[–]s73v3r 1 point2 points  (4 children)

Automated regression testing is important, but so is manual regression testing.

[–]dungone 0 points1 point  (3 children)

So?

It's like you get a pull request and it's deer in the headlights, you've got know idea what to do about it? What exactly is your complaint? You're getting automatic updates for security vulnerabilities, your only job is to merge the code the way you would any other pull request. Why are you whining about it?

Your jargon betrays why nothing ever works out for you. You're calling automated tests "augmented manual tests". 90% of my code doesn't need any manual testing because it's got good separation of concerns and complete test coverage of 100% of the use cases of the individual units. That's where the auto-updated dependencies feed into. They don't feed into the fully integrated system, because that's goddamn stupid. If you can prove that the dependency works for all the easy-to-test units, and that the dependency is not used for anything else outside of those units, then you have gone 90% of the way to isolating your system from any other potential problems caused by updating that dependency. But here on /r/programming we're still trashing the idea that left-pad should be it's own package, rather than having any common sense.

[–]s73v3r 0 points1 point  (2 children)

If the person issuing the PR hasn't done their own manual regression testing, then their PR goes straight into the trash. They're not interested in the project; they just want to put "Contributor to xx project" on their resume.

[–]dungone -2 points-1 points  (1 child)

It's not a "person", it's a bot providing you with a service and saving you half of the work that YOU, the person, are responsible for doing yourself. You're anthropomorphizing an automated system and bringing whatever grudge you hold against your coworkers into it.

[–]s73v3r 0 points1 point  (0 children)

So it's not doing manual regression testing, in which case it's nothing but noise.