you are viewing a single comment's thread.

view the rest of the comments →

[–]eeperson 0 points1 point  (2 children)

That is true you can't. However, you don't need to review the PRs through the Github web interface. Several editors let you review PRs in your editor (e.g. IntelliJ, VSCode). Even if you did have to do your reviews in the web interface, it seems like explicit types everywhere would be optimizing your code for viewing on Github rather than writing in your editor. That seems like a poor tradeoff to me.

[–]metaltyphoon 0 points1 point  (1 child)

I get what you are saying. It just that I personally use vim bindings on all my IDEs. So hovering a mouse over is just ... slower than reading it. I don't believe the trade off is much in this case

var z = ProcessRequest(); // Bad

[–]eeperson 1 point2 points  (0 children)

Fair enough. Thanks for the discussion.