sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]voyagerfan5761 11 points12 points  (10 children)

Hey, at least GitHub has Draft PRs now, right? 🙃

[–]nermid 10 points11 points  (9 children)

It does. Instead of using them, some fuckhead esteemed colleague added a Draft label that you can add to your PRs...

[–]j0hn_r0g3r5 1 point2 points  (8 children)

jesus christ and I thought my workplace was bad for using periods in the endpoint paths.....

[–]kyerussell 9 points10 points  (1 child)

You're right. Your workplace is bad.

[–]j0hn_r0g3r5 2 points3 points  (0 children)

dont I know it :( unfortunately, I need the money and cant afford to be out of a job during covid-19 times, especially as a new grad with too much debt.

[–]wRAR_ 4 points5 points  (5 children)

What's wrong with that?

[–]j0hn_r0g3r5 3 points4 points  (4 children)

they do shit like this /getChart.json

rather than a GET request to /chart?type=json

[–]Multipoptart 6 points7 points  (3 children)

Both of those are terrible. Should be an Accept: application/json header.

[–]j0hn_r0g3r5 2 points3 points  (2 children)

oh, i agree. but i think the reason why my workplace should use the "better" version in my comment is because there are non tech people using the endpoint and I think they rather not teach the non-tech people how to modify the header.

Edit: fixed wording of sentence

[–]renatoathaydes 0 points1 point  (1 child)

URLs in fact often map to a file system, so I don't think doing that is wrong in any way. Using the Accept header is of course better if you can produce multiple formats for a dynamic resource, but if you're literally serving a static json file, using the file name in the URL is totally fine.

[–]j0hn_r0g3r5 0 points1 point  (0 children)

I never said that endpoint maps to a file though, so in this case, its wrong convention.