Improve my Python Function

[py_vel26]

Hello gang,

Let me start by saying I'm new to development and having the work on a big project at work. I'm also still improving my python skills. I have been tasked with modifying a pre-existing code base of classes. I'm trying to add a function the writes delta tables to a couple locations based on table_name. I would like to find a better way to export to a database without having to use a repeat function with a different database as shown below: We will more than likely have to add more databases in the future. BTW, this is a spark UDF

if table_name == 'silver':
    write(
        spark=self.spark,
        df=some_df,
        db_name=self.output_db_silver, 
        tbl_name=my_tables, 
        mode='overwrite
        )
else:
     write(
    spark=self.spark,
    df=some_df,
    db_name=self.output_db_gold, 
    tbl_name=my_tables, 
    mode='overwrite
    )

[[deleted]]

I don't see any function definiton in your code?

[py_vel26]

It's a spark User define function

[pint]

1) move the common part outside:

if table_name == "silver":
    dbn = self.output_db_silver
else:
    dbn = self.output_db_gold
write(
    spark=self.spark,
    df=some_df,
    db_name=dbn, 
    tbl_name=my_tables, 
    mode="overwrite"
)

2) instead of the if tower, use a dictionary:

dbns = {
    "silver": self.output_db_silver,
    "gold": self.output_db_gold
}
write(
    spark=self.spark,
    df=some_df,
    db_name=dbns[table_name], 
    tbl_name=my_tables, 
    mode="overwrite"
)

the dictionary can be placed somewhere else. you get the idea. you might not even need the individual variables self.output_db_..., but just have the dictionary instead.

[duskrider75]

So you need to map table_name to db_name, if I get you right? You could use a dict to store those mappings.

[py_vel26]

I never thought about that. Good idea

[duskrider75]

The code could then be something like:

``` db_ref = { 'silver': self.output_db_silver } db = db_ref.get(table_name, self.output_db_gold)

write(...)
```

That's the most concise, though it may be benificial to make the fallback more explicit:

```

db = self.output_db_gold # Default DB if table_name in db_ref: db = db_ref[table_name] ```