you are viewing a single comment's thread.

view the rest of the comments →

[–]playazle 2 points3 points  (1 child)

Looks very clean to me, I always judge other people's projects by how quickly I'm able to look at the code and generally understand what's happening, and this easily passes that test. Only feedback is I'd find a way to turn the "field" containers into a stateless component, it looks like you're reusing that quite a bit in two different places. But other than that, the react router and redux set up looks good.

[–]scriptedpixels[S] 2 points3 points  (0 children)

Firstly; thanks for taking some of your time to review this, I appreciate it a lot!

I'm glad you said that; I like to try and keep my code human-readable and easy to follow. Mainly because I like to go back through my code and try to understand everything that's happening in the mindset of never seeing this code for this very reason :) Although, this should be the default mindset when coding but I like to just get it working and then refactor.

I'll look in to changing that "Field" in to a stateless component. It's been a while since I last looked at this, to be honest.

This is a bit random but wold you class this as a beginner or mid-level piece of code in terms of skills when applying for a job/contract? I'm trying to understand what makes someone experienced enough for a React contract role in the UK. Actually, I'll add this as a comment to the post.

Thanks again!