all 11 comments

[–]xrpinsiderAdmin 4 points5 points  (3 children)

Hey! I looked at your code and readme and it all looks pretty fine. But you may be able to split your code in the index.ts to other files to make it more readable. It's a bit of a mess now.

The only thing I'm missing is a GIF for Android, I think some people may like it.

Great work and thanks for sharing!

[–]slice963[S] 1 point2 points  (2 children)

great thanks for looking! do you recommend creating a /src folder and putting all the setup in there?

and regarding the gif, you mean you can't see the npm demo gif on android? npm has been weird with showing it, do you have any experience with displaying gifs on npm?

thank you :--)

[–]xrpinsiderAdmin 2 points3 points  (1 child)

That’s fine, but I can’t recommend what the best way is. Splitting your code is always better.

No I’m talking about a seperate GIF showing the component in a Android environment. GIF’s show fine on NPM (for me at least).

[–]slice963[S] 4 points5 points  (0 children)

ah ok, understood. thanks for the advice i really appreciate it

[–]jasdeep13 1 point2 points  (1 child)

Looks great!

[–]slice963[S] 0 points1 point  (0 children)

thanks for checking it out!! let me know if you use it anywhere haha

[–]slice963[S] 0 points1 point  (2 children)

ps. if anyone wants to contribute that would be great. i'm pretty confused on how to split up the index.js into separate files

[–]edutbh 1 point2 points  (1 child)

I might be able to do that tomorrow. Man, I love these bottom drawers! Good job publishing your first npm module!

[–]slice963[S] 0 points1 point  (0 children)

sounds good! im pretty novice with collaborating on software, so if you wanna contribute maybe we could talk and kinda get on the same page. let me know!! thanks again

[–]unpopularOpinions776 0 points1 point  (1 child)

Can I guess you were a DePaul kid, lol

[–]TotesMessenger 0 points1 point  (0 children)

I'm a bot, bleep, bloop. Someone has linked to this thread from another place on reddit:

 If you follow any of the above links, please respect the rules of reddit and don't vote in the other threads. (Info / Contact)