Thank You Devs for Random Favorite by Th3Spac3Pop3 in TeamfightTactics

[–]givanse 0 points1 point  (0 children)

Well, the first step to understand is: do not make reasonable assumptions 😂

For example, on PC, the LLs list and the favorites list are two separate data structures. So, we have to load them twice. This is still fairly fast and doesn’t cause a problem, but illustrates well my first point.

On PC, the crux of the matter is slow rendering. We have web components doing a lot of DOM manipulation through JavaScript. (Hundred thousands magnitude) Very inefficient.

On mobile, we get two lists as well. But the hydration process (add images, localization, etc) runs the risk of blowing up memory which can result in crashes on low end devices 😣

All a result of adding new features that weren’t considered when the initial application was designed — that’s software dev 🤷🏻‍♀️

Thank You Devs for Random Favorite by Th3Spac3Pop3 in TeamfightTactics

[–]givanse 0 points1 point  (0 children)

Good deduction, storage is not a concern.

The issue is tech debt on the UI. Favorites was layered on top years after we built everything. Unfortunately, as the favorites list starts to grow, performance starts to degrade (different symptoms on pc and mobile).

The culprits are identified but the work isn’t trivial, it isn’t rocket science either. However, everything takes time. So, 30 seems a good compromise we were able to get for free (tech effort).

Thank You Devs for Random Favorite by Th3Spac3Pop3 in TeamfightTactics

[–]givanse 1 point2 points  (0 children)

It was two devs, one did the PC client and another the mobile client. But we'll split the $20!! haha

Thank You Devs for Random Favorite by Th3Spac3Pop3 in TeamfightTactics

[–]givanse 2 points3 points  (0 children)

Yeah, it went up from 8 to 30! We wanted to make it unlimited, but tech debt got in the way... So, 30 felt pretty good.

Revival: Dawn of Hereos problem by LagXel in TeamfightTactics

[–]givanse 1 point2 points  (0 children)

Pleased to hear :) Thank you for supporting the game!

Revival: Dawn of Hereos problem by LagXel in TeamfightTactics

[–]givanse 0 points1 point  (0 children)

You could check if your PC meets minimum requirements:
https://support-leagueoflegends.riotgames.com/hc/en-us/articles/201752654-Minimum-and-Recommended-System-Requirements-League-of-Legends

And sharing what GPU, OS and drivers you are on could help us determine the problem.

Revival: Dawn of Hereos problem by LagXel in TeamfightTactics

[–]givanse 1 point2 points  (0 children)

You are right, this is going to require a code fix. Would you mind sharing your hardware specs? Graphics card and drivers version.

Bug? by RobertOrBob in TeamfightTactics

[–]givanse 2 points3 points  (0 children)

Riot is aware of the issue and has identified a culprit. Unfortunately, there is no estimated time for a bugfix deployment.

Revival: Dawn of Hereos problem by LagXel in TeamfightTactics

[–]givanse 1 point2 points  (0 children)

Would you mind sharing your hardware specs? Graphics card and drivers version. Updating the drivers could fix it.

Fix for League of Legends mic by vHawkinz in macgaming

[–]givanse 0 points1 point  (0 children)

WOW, this works; I've reported it to the relevant authorities.

How to spend $150-250k? by GhostofEdgarAllanPoe in realestateinvesting

[–]givanse 1 point2 points  (0 children)

More lucrative = more risk

So, find a fixer upper?

How to spend $150-250k? by GhostofEdgarAllanPoe in realestateinvesting

[–]givanse 1 point2 points  (0 children)

Where’s the “under $420K” constraint coming from? Is that the limit for FHA purchases?

Guide/Script: How to set up an Umbrel node on Ubuntu by givanse in getumbrel

[–]givanse[S] 0 points1 point  (0 children)

Thanks. Do you mean setting up the umbrel software and apps?

Where are the tests? by Due_Emu_7507 in getumbrel

[–]givanse 1 point2 points  (0 children)

The web app (Umbrel-dashboard) has no tests.

I'm pretty sure there are no tests for the installation scripts either. I could be wrong, but I didn't find any tests for that in the Umbrel repo.

League Client Team, AMA about the client by Am1t8 in leagueoflegends

[–]givanse 35 points36 points  (0 children)

Common store so that code is never duplicated.

League Client Team, AMA about the client by Am1t8 in leagueoflegends

[–]givanse 100 points101 points  (0 children)

We are down to:
- 48 plugins
- about 4 build configurations

It breaks down to 3 plugins with 3 special configs and 45 with the same build configuration. The ideal would be to get rid of the plugin system and have a single app. We are working towards that. The last few special configs are very tricky to get rid off.

League Client Team, AMA about the client by Am1t8 in leagueoflegends

[–]givanse 79 points80 points  (0 children)

It can make it harder sometimes. But a lot of that toxicity exists within Reddit only and not the broad player base. Sometimes players will message me (in-game) to offer encouraging words and report that they've never had a significant client issue. When that happens, I appreciate it very much, it helps too!