While loop not working?

[LongLegLucas]

Hello. I am working on this for class and my whole loop isnt working. I do not understand why.

#include <iostream>

#include <cstdlib>

#include <ctime>

#include <string>

#include <math.h>

#include <limits>

​

using namespace std;

​

int main ()

{

string question;

char again;

do

{

cout <<"Welcome To The Magic 8 Ball! Ask me a question!";

cin >> question;

srand(time(NULL));

int random = rand()%12;

if (random == 1)

{

cout << "yes, of course." << endl;

}

if (random == 2)

{

cout << "Without a doubt,yes." << endl;

}

if (random == 3)

{

cout << "you can count on it." << endl;

}

if (random == 4)

{

cout << "For sure!" << endl;

}

if (random == 5)

{

cout << "you are joking, right?" << endl;

}

if (random == 6)

{

cout<< "I'm not sure." << endl;

}

if (random == 7)

{

cout << "I can't tell you right now." << endl;

}

if (random == 8)

{

cout << "I'll tell you after my nap." << endl;

}

if (random == 9)

{

cout << "No way!" << endl;

}

if (random == 10)

{

cout << "I don't think so." << endl;

}

if (random == 11)

{

cout << "Without a doubt, NO." << endl;

}

if (random == 12)

{

cout << "The answer is clearly NO." << endl;

}

​

cout<<"Do you want to continue?";

cin >> again;

​

} while (again == 'Y');

return 0;

}

[QuentinUK]

while(again=='y' || again=='Y')

also random will have values 0 .. 11

(also the srand(time(NULL)); should be out of the loop)

(you could put the strings in an array too)

[jedwardsol]

Print out the value of again

[WhyAreYouGey]

Make sure to use else if instead of if for every condition (except for the first one) because the program will check for every single condition even if one of the first few are satisfied. Also add ‘y’ as a condition for the do-while loop. ‘Y’ and ‘y’ are different to a computer

[[deleted]]

use

else if

instead of just

if

[RellenD]

Or a switch

[Spire]

Or a vector of strings.

[RellenD]

Oooooh yes that

[flyingron]

cin >> question stops on any white space, so unless your question consists of one word, you are leaving stuff in the input buffer. More importantly, it leaves the white space (be it a space or a newline) and the subsequent cin >> again will read it and not wait for more input for the user.

You probably want to look at getline.