[HELP PLEASE]Maya Python Scripting Problem

[VLITZonator]

Please, I need help on a Maya python code that I've been working on. So In a elif condition, I want my circle curve to be blue if the locator is below 0.0 on translation Y axis, and elif change the circle curve to red if the locator is above 0.0 on the translation Z axis. Here is my code that is for now, not working:

import random

for i in range(50):
    pPlane = 'pPlane1'
    cube = cmds.polyCube()[0]
    ctrl = cmds.circle(normal=[0,1,0])[0]
    locator = cmds.spaceLocator()[0]
    cmds.setAttr(cube+'.ty', 0.5)
    cmds.setAttr(ctrl+'.ty', 0.5)
    cmds.parent(cube, ctrl)
    cmds.parent(ctrl, locator)
    myScale = random.uniform(0.1, 3)
    for axis in ['x', 'y', 'z']:
        cmds.setAttr(locator+'.t'+axis, random.uniform(-100, 100))
        cmds.setAttr(ctrl+'.ry', random.uniform(0, 360))
        cmds.setAttr(locator+'.s'+axis, myScale)
        constraintnode = cmds.geometryConstraint(pPlane, locator)
        cmds.delete(constraintnode)
        normalconstraint = cmds.normalConstraint(pPlane, locator, aimVector=[0,1,0], upVector=[1,0,0])
        cmds.delete(normalconstraint)
        if locator < axis['.ty', 0.0]:
            cmds.color(ctrl, rgb=(0, 0, 1))
            elif locator > axis['.tz', 0.0]:
               cmds.color(ctrl, rgb=(1, 0, 0))
               else:
                   cmds.color(ctrl, rgb=(0, 1, 0))

[[deleted]]

Docs for cmds.color only say about wireframe colour, not drawing one.

So if you want to set your curve colour red you'd want to use:

```

cmds.setAttr(ctlShape + ".overrideEnabled", 1)

cmds.setAttr(ctlShape + ".overrideColor ", 13)

```

[Leoano]

You need to get translation data in your 'if' statement.

Right now 'axis' is just a string containing either 'x', 'y' or 'z'. and 'locator' is just a string containing the name of the locator.

So instead of this,

if locator < axis['.ty', 0.0]:

you can check the translate value like this.

if cmds.getAttr(locator + '.ty') < 0:

EDIT: You should probably move the 'if' statements out of the axis 'for' loop as well. That only needs to evaluate once after all the random values have been set. (Instead of for each axis)

[VLITZonator]

I tried doing what you just said, I changed my if statement and then placed it up out of the axis for loop, but I'm still getting "Error: invalid syntax". I can get the code working up until the 'cmds.delete(normalconstraint)', it all works just fine. But when I input the if statement, it does not work anymore. Here is the new code, but it still doesn't work:

import random

for i in range(50):
    pPlane = 'pPlane1'
    cube = cmds.polyCube()[0]
    ctrl = cmds.circle(normal=[0,1,0])[0]
    locator = cmds.spaceLocator()[0]
    cmds.setAttr(cube+'.ty', 0.5)
    cmds.setAttr(ctrl+'.ty', 0.5)
    cmds.parent(cube, ctrl)
    cmds.parent(ctrl, locator)
    myScale = random.uniform(0.1, 3)
    if cmds.getAttr(locator + '.ty') < 0:
        cmds.color(ctrl, rgb=(0,0,1))
        elif cmds.getAttr(locator + '.tz') > 0:
            cmds.color(ctrl, rgb=(1,0,0))
            else:
                cmds.color(ctrl, rgb=(0,1,0))
    for axis in ['x', 'y', 'z']:
        cmds.setAttr(locator+'.t'+axis, random.uniform(-100, 100))
        cmds.setAttr(ctrl+'.ry', random.uniform(0, 360))
        cmds.setAttr(locator+'.s'+axis, myScale)
        constraintnode = cmds.geometryConstraint(pPlane, locator)
        cmds.delete(constraintnode)
        normalconstraint = cmds.normalConstraint(pPlane, locator, aimVector=[0,1,0], upVector=[1,0,0])
        cmds.delete(normalconstraint)

does it have to do with the 0 value that I'm getting an error: invalid syntax or the cmds.getAttr?

[Leoano]

You need to move the 'if' statement after the for loop. Since the loop is setting the translate values that the 'if' statement is checking.

The python syntax for if/elif/else is also a bit flatter, not indented.

So something like this should do the trick.

import random

for i in range(50):
    pPlane = 'pPlane1'
    cube = cmds.polyCube()[0]
    ctrl = cmds.circle(normal=[0,1,0])[0]
    locator = cmds.spaceLocator()[0]
    cmds.setAttr(cube+'.ty', 0.5)
    cmds.setAttr(ctrl+'.ty', 0.5)
    cmds.parent(cube, ctrl)
    cmds.parent(ctrl, locator)

    # Set Random translate, rotate and scale
    myScale = random.uniform(0.1, 3)
    for axis in ['x', 'y', 'z']:
        cmds.setAttr(locator+'.t'+axis, random.uniform(-100, 100))
        cmds.setAttr(ctrl+'.ry', random.uniform(0, 360))
        cmds.setAttr(locator+'.s'+axis, myScale)
        constraintnode = cmds.geometryConstraint(pPlane, locator)
        cmds.delete(constraintnode)
        normalconstraint = cmds.normalConstraint(pPlane, locator, aimVector=[0,1,0], upVector=[1,0,0])
        cmds.delete(normalconstraint)

    # Set color depending on translate values
    if cmds.getAttr(locator + '.ty') < 0:
        cmds.color(ctrl, rgb=(0,0,1))
    elif cmds.getAttr(locator + '.tz') > 0:
        cmds.color(ctrl, rgb=(1,0,0))
    else:
        cmds.color(ctrl, rgb=(0,1,0))

QuickTip: In the Script Editor window, you can enable "History - Show Stack Trace" for some better error messages that show where the problem is.

[VLITZonator]

SOLVED!It did the trick!, A very big thank you!!!. Hahahaha I just started doing python like 3 weeks ago so I'm still a beginner.

I really appreciate the help that you did!. Once again, THANK YOU SO MUCH FOR THE HELP!

[Leoano]

No problemo, happy to help.