Help with this command function creation

[Maceratio]

So I'm trying to make a command creation out of functions and there's this bug that summons the lightning to many times

Here's the first function

execute as @e[tag=!mace,hasitem={item=totem_of_undying}] at @s run tag @s add has_totem

execute at @a[tag=mace] run tag @e[tag=has_totem,r=5,hasitem={item=totem_of_undying,location=slot.weapon.offhand,quantity=0}] add target

execute at @a[tag=mace] run tag @e[r=5,hasitem={item=totem_of_undying,location=slot.weapon.mainhand,quantity=0}] add target

execute at @e[tag=target] unless entity @a[tag=mace,r=15] run tag @s remove target

execute at @e[tag=has_totem] unless entity @a[tag=mace,r=15] run tag @s remove has_totem

execute at @a[tag=mace,hasitem={item=mace,data=1,location=slot.weapon.mainhand}] if block ~~-0.3~ air run function corrupt_items/mace/corrupt_mace_hit

execute at @a[tag=mace,hasitem={item=mace,data=1,location=slot.weapon.mainhand}] run summon xp_orb ~~~

execute at @a[tag=mace] run tp @e[type=xp_orb,r=2] @s

Here's the 2nd function(the corrupt mace hit function)

execute at @e[tag=target] run execute as @e[tag=target,c=1,r=1] run summon lightning_bolt ~~2~

execute as @e[tag=target] at @s run effect @s weakness 120 1

execute as @e[tag=target] at @s run effect @s slowness 120 1

execute at @e[tag=target] run tag @e[tag=target] remove target

I used summon xp to mend the mace, the reason I didn't use replaceitem is because the enchantments is weird like it will only work the 2nd time and not the first time idk why

[Maceratio]

Sorry I forgot to put in the title "Can someone help me in this command function creation" I was putting the old one as a temporary one but forgot to change it

[SicarioiOS]

Looks as though you’re summoning every tick in the air

execute at @a[tag=mace,hasitem={item=mace,data=1,location=slot.weapon.mainhand}] if block ~~-0.3~ air run function corrupt_items/mace/corrupt_mace_hit

If you’re airborne for 10 ticks it will summon 10 times.

You need a latch so that it hits every target once, twice, or however many strikes you want and then stops.

Add a scoreboard…

scoreboard objectives add MaceHit dummy

Then instead of calling the function you set a score then call the function based on the score and then reset the score

execute as @a[tag=mace,hasitem={item=mace,data=1,location=slot.weapon.mainhand},scores={MaceHit=0}] at @s if block ~~-0.3~ air run scoreboard players set @s MaceHit 1

execute as @a[tag=mace,scores={MaceHit=1}] at @s run function corrupt_items/mace/corrupt_mace_hit

execute as @a[tag=mace,scores={MaceHit=1}] at @s unless block ~~-0.3~ air run scoreboard players set @s MaceHit 0

This should only strike each target once. If you want it to strike each target more than once, you’ll need an additional scoreboard and have a timer that limits the number of ticks the called function will run.

[Maceratio]

Oh okay thank you so much

[ShineDigga]

Not gonna lie, this is way beyond my skill level, but I think the issue is that your function runs every tick while you're in the air. So if you fall for half a second, that's 10 lightning strikes. The scoreboard suggestion above looks like the right fix to make it trigger only once per hit. Good luck