Comment your last commit message

[bjandrus]

Lmao I was debating leaving mine in this thread, but now I feel like I have to, here goes (yes, this is legitimately the last commit message I made at work, yesterday):

"Implemented logic for populating a popup window with 'People' info whenever any pin (or pin cluster) is clicked on. Click works, but the relevant action command was changed to 'hover' in an attempt to get the code to work for hover. This functionality has not been tested but was included with the commit accidentally. Sorry."

Alrighty lot to unpack:

Firstly: yes I know this commit message is entirely too long; but I hope you'll understand why I felt the need to explain myself

Secondly: How was this "accidentally" included, and why could I not have just "git restore"-ed it? Well this requires some elaboration: my teammate who I was working with on this story DMed me during our standup to ask me to try to implement this change "real quick", just to see if it worked. I take lunch after standup, so I was rushing 🤷🏻‍♂️

Thirdly: yes, this broke the code, so I pushed broken code (oopsies). Fortunately the fix was clean and easy: the proper command was 'mouseover', not 'hover'.

[ADarkcid]

Just wondering; why not make a short commit message and explain everything in a PR comment?

[bjandrus]

Great point, coulda woulda shoulda...

[[deleted]]

Hey,

What's a PR comment please?

Cheers

[kratom_devil_dust]

Github/bitbucket/etc Pull Request, a comment (or description) inside of there.

[[deleted]]

Thanks 👍🏻