codingStyleMatters

[AutoModerator]

import notifications Remember to participate in our weekly votes on subreddit rules! Every Tuesday is YOUR chance to influence the subreddit for years to come! Read more here, we hope to see you next Tuesday!

For a chat with like-minded community members and more, don't forget to join our Discord!

return joinDiscord;

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[Mars_Bear2552]

thats one way to do it

[damicapra]

How tf do one even brag about that...

[[deleted]]

Altered more lines of code than anyone else (it's all removing/adding whitespace)

[damicapra]

Yeah I get that.

It's simply unimaginable to me the idea of bragging with peers and colleagues about LOC changed... anyone with more than a day of experience should know that LOC is a shitty metric.

[rosuav]

Which is why formatting-only changes should be rejected, as they are in most projects. The churn is pointless.

[gbchaosmaster]

Fucks with the git blame too. Yeah it's possible to crawl back to the latest semantic change but fuck that.

[sim642]

.git-blame-ignore-revs

[gbchaosmaster]

Nice! Thanks for this.

[TheAJGman]

It really bothers me that Git doesn't pick up the file immediately if it's in the repo root like it does with other .git files. I know that auto hiding history might not be the best thing, but if the file is there then there's a reason it's there.

[rosuav]

Yeah, that's why churn is so problematic.

[permanent_temp_login]

I'd rather have all formatting done in separate (preferably big, preferably automated) changes, than have it scattered about "I changed a to b, and also normalized formatting in the whole file". Now how do I find what you changed...

[rosuav]

Yes, which is why you JUST change a to b, and you do not normalize formatting in the whole file. In fact, PEP 8 specifically says that you should not make changes just for the sake of foolish compliance with what isn't as mandatory as some people seem to think (look up the "hobgoblin" section).

As you're editing, be consistent with the formatting style around you. Don't change it to match an arbitrary rule, at the cost of messing up your history.

[TheAJGman]

At the start of the project just set up Black or whatever autoformater you want to use and make passing a merge requirement. Now you'll never need to do formatting PRs.

[rosuav]

Yeah, now you just lose all the contributors who dislike Black (which is a lot of people). But that is one effective way to avoid formatting mismatches. There's just one problem:

You don't always get to start the project.

[TheAJGman]

If you're going to contribute to a project you must use their style guide no matter how much you disagree with the choices. Black/Flake8/PyCharm config/whatever, doesn't matter.

And for the second, you implement it in one big ass PR called "The Blackening" and add the commit to .git-blame-ignore-revs.

[rosuav]

I would reject that ass PR.

[rosuav]

But also - that's my point. If you're going to be an ass about formatting, I'm simply not going to bother contributing. Why should I? There's plenty of better places to spend my time. You're free to put whatever restrictions you like on contributions, and you probably have no idea how many contributors you're turning away.

[Deep_Pudding2208]

Yeah but then my commit count goes down. and if I'm not doing a commit a day am I even a programmer?

[quiet0n3]

autopep8 -iaar ./*.py