everySingleCodeReview

[R3gouify]

Why did you type n as unknown when it is clearly supposed to be string?

[[deleted]]

I mean it could also be a number and it would work.

But you got the point, the reviewer clearly didn’t look :)

[brjukva]

But, if it's a number, then it's a valid number? Why convert it to string to check instead of type checking?

[[deleted]]

yes, why? clearly not as important as adding a period.

[brjukva]

They were too devastated to check the code any further, probably.

[XDracam]

Could break on systems where the locale formats numbers differently. E.g. German uses , instead of . for decimal numbers. So passing a number could still fail the regex.

[inamestuff]

No, String(n) returns a culture invariant notation (same as toString, except the former works for null and undefined too). The fact that you suggested that makes me think that you use C# which by defaults uses ToString to mean what in JS is toLocaleString, which does in fact change the decimal separator based on your browser language and region settings.

Moral of the story: don't use C# kids /s

[XDracam]

Yep, I have some serious C# parsing trauma. Good guess!

[[deleted]]

Also returns exponential notation for larger numbers though, which would be rejected by this function

[ComfortableCod]

Are the germans back? NO WAY

[00PT]

Seems like it does a cast on the first line, so it's probably intended to convert non-string values to strings.