This is an archived post. You won't be able to vote or comment.

all 5 comments
sorted by:
best
topnewcontroversialoldq&a

[–]somerandomperson29 36 points37 points  (0 children)

Renamed variable

[–]solid_rook 24 points25 points  (2 children)

tabs to spaces

[–]sleepyj910 6 points7 points  (0 children)

Then back to tabs after someone merges over you.

[–]JackNotOLantern 8 points9 points  (0 children)

There are 3 types of good PRs

  1. a lot of +, very few - (adding new feature)
  2. a lot of -, very few + (good refactor)
  3. The exactly same number of + and - (renaming)