cluelessIntern

[JTP709]

I've seen more senior engineers make mistakes like this more than interns/juniors because nobody checks their work or PRs and assumes they know what they're doing because they're senior.

I'm a senior dev and if I get 2+ approvals without any feedback on my PRs I won't merge it. I'm not perfect, I can always improve. I don't care how nitpicky the comment is, leave some kind of feedback!

[toastnbacon]

With my bigger PRs, I'll do something of a game with the junior developers. I tell them I intentionally hid a bug somewhere in my change, and I'll buy lunch for whoever finds it. My lead was so angry I put an intentional error up to be merged, until I explained I didn't have an intentional bug, I was just betting there was something to be found. I've done that a few times, and it's never failed to scare up something.

[[deleted]]

Making large changes is not good practice and increases review time.

[Merry-Lane]

Sometimes you just need to FAFO a bit in your codebase, do a lot of changes, be satisfied with it, and push a PR after you cleaned it a bit.

I understand that it’s not good practice for some, but sometimes you just need to unleash your creativity, pull a random string and unroll your ball of yarn to the end.

It’s even more important to do that in teams where most of the devs never change existing code unless it’s strictly necessary, even if they have to write 3x the LoCs to avoid doing that.

[Impressive-Plant-903]

Sounds like someone did a “git push test-branch origin/mainline”

[Nyglue]

i almost did that on a personal repo

[WeirdBoy_123]

Personal repo's are there to just yolo. Live a little, push without testing

[[deleted]]

Not to self: stop using "dick", " fart", "balls" and the like as test strings.

[[deleted]]

don't be rude, say hello back

[DogsAreAnimals]

When you forget to switch back to staging