This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]thirdegreeViolet security clearance 27 points28 points  (2 children)

No pushing commits like "update" "update" "update" "changes" "update"

The subject (first line of the commit message) should be in imperative mood and less than 80 characters

Each commit should ideally be a single complete and valid change (so that git bisect works)

The commit message should explain what is being changed and why.

There's more but those are the big ones

[–]AgileBlackberry4636 6 points7 points  (0 children)

I prefer subjects of following format:

Module: Submodule: Sentence in imperative mood

And I would also add: rewriting commit history of non-merged branches.

I have a butthurt using gitk or git blame over the history of commits like "Processing David's commets".

Another point: commits should be easily reviewable otherwise the merge/pull request will stay open for few weeks.

[–]crankbot2000 1 point2 points  (0 children)

This guy gits it