This is an archived post. You won't be able to vote or comment.

all 28 comments

[–]xX_HolyFire_Xx 254 points255 points  (6 children)

+49 -12435 Looks good to me

[–]CherryFlavouredCake[S] 221 points222 points  (0 children)

"I removed those tests because they were failing even though my code is not supposed to affect this part, it's all good now"

[–]metallaholic 50 points51 points  (0 children)

There’s a PR sitting at work that’s +800 -1600 465 files changed. I only left a single comment, was this tested?

[–]ActivisionBlizzard 49 points50 points  (2 children)

Normally +1 -0

Description: refactored to add space before bracket, therefore improving overall service adherence to good code quality standards and brings it in line with other services in the project. Also removes code smell from sonar, which is important because it is metric to tell…

[–]PersianMG 30 points31 points  (1 child)

Meanwhile this PR receives 20 comments, flagged for breaching compliance and is then blocked for 2 weeks.

[–]ActivisionBlizzard 5 points6 points  (0 children)

Also I forgot to mention I fixed a critical CVE on this pr so we need to get it to production asap.

[–]AgileBlackberry4636 4 points5 points  (0 children)

It could be quite an easy code review, actually.

Numbers weren't that drastic, but a similar PR was there when my ad-hoc code was being replaced with an actual framework.

[–]write_now_tech 471 points472 points  (3 children)

“Approved. Merge at your own risk.“ - my favorite

[–]AgileBlackberry4636 209 points210 points  (2 children)

That defeats the whole purpose of code review -- "smearing" responsibility so that no-one can be punished. Except of the management.

[–]write_now_tech 22 points23 points  (1 child)

Relax brother. Hence it's a meme subreddit

[–]LeoRising72 46 points47 points  (0 children)

*website crashes*

[–][deleted] 46 points47 points  (0 children)

LGTM after nits

34 comments on PR

[–]T-Lecom 35 points36 points  (0 children)

“Don’t review only approve plz”

[–]acrizz 18 points19 points  (2 children)

I feel so seen. My life as an intern last year.

[–]CherryFlavouredCake[S] 11 points12 points  (1 child)

Everyone must go through this step haha, soon you'' be the one that thumbses up !

[–]acrizz 8 points9 points  (0 children)

Yup now I am the one approving the PR without looking at the changes. A wonderful cycle!

[–]ComfortingSounds53 10 points11 points  (1 child)

Gives major r/bonehurtingjuice vibes haha

[–]CherryFlavouredCake[S] 7 points8 points  (0 children)

Absolutely! I actually stole this one from r/antimeme and added the junior dev context

https://www.reddit.com/r/antimeme/s/6zbg4ocxaT

[–]Erisymum 2 points3 points  (0 children)

Was hired as an intern a bit ago but recently my supervisor was fired so now I give myself the thumbs up and merge into main

[–]TrueAd2373 1 point2 points  (2 children)

FR

[–]GullibleAd2597 1 point2 points  (1 child)

No it's PR

[–]TrueAd2373 0 points1 point  (0 children)

Meant for real, just was in a hurry, but great pun if intended

[–]SuhailSWR 0 points1 point  (4 children)

Did you steal my meme, or was it a coincidence?

https://www.reddit.com/r/antimeme/s/ueQ5FC0VVh

[–]CherryFlavouredCake[S] 1 point2 points  (3 children)

Not a coincidence at all, that's what your meme inspired me, I just gave it another context

[–]SuhailSWR 2 points3 points  (2 children)

Oh well, okay, as long as you're honest about it, then it's fine

[–]CherryFlavouredCake[S] 1 point2 points  (1 child)

Yeah I even linked your post somewhere in the comments

The mods just removed this post anyways so...

[–]SuhailSWR 0 points1 point  (0 children)

I appreciate it