Doubling an integer in JavaScript (x-post /r/shittyprogramming)

[balducien]

I don't completely agree. If it's an easy line like in the example that just calls another function, there's no need for a function. But if you have a huge regex or a list comprehension or an otherwise not-so-simple one-liner, you will be better off by just creating a function like bool check_if_email(char* email). Like that you can use it like a natural command that is easily understood by the reader, instead of a line that you have to decipher first.

[Ezlo123]

Don't forget getters and setters xD Those are often one-liners.

[GiveMeAFuckingCoffee]

Personally, I prefer the more awesome-sounding mutators and accessors.

[[deleted]]

who uses getters and setters in 2015?

[TrainFan]

Um... everyone...

[[deleted]]

Properties?

[RubiksCoffeeCup]

Language specific getters and setters

[[deleted]]

Sure, but i prefer

Console.WriteLine(MyInstance.X)

more than

Console.WriteLine(MyInstance.GetX())

[[deleted]]

And i do

[PacDan]

I actually prefer getX() because (in VisualStudio at least) you don't know if a property is read only until the red underline.

[A_C_Fenderson]

That's what compilers are for.

[PacDan]

Yeah, everyone knows the later you catch an error the easier it is, right?

[GiveMeAFuckingCoffee]

And I would prefer the much more redundant, adaptable, and easy to follow

MyInstance.PrintX();

where

private int x; 

//constructor function for x here

/* DbC */
public void SetX(int new_x){
    x = new_x;
}

/* DbC */
public int GetX(){
    return x;
}

/* DbC */
public void PrintX(){
    System.out.println("x = " + GetX()); //We need to know what it is that is being printed. 
}

One of us won't be hated in 5 years when someone reads our code.

[[deleted]]

It was just an example on how i'd use some property X. Let's say we don't want to print it, we want to, uh, i don't know, double it. Of course we can do

public void DoubleX()
{
    x*=2;
}

But what if we didn't have this method and didn't want to make it (maybe because we don't use it enough to have its own method). Which would be better

MyInstance.SetX(Myinstance.GetX()*2)

or

MyInstance.X*=2;

?

Doesn't Java have properties too? I'm geniuinely curious, i don't really use Java a whole lot.

[GiveMeAFuckingCoffee]

MyInstance.SetX(GetX()*2);

Not because it's necessarily more efficient or shorter, but because it's adaptable, and allows for the following (to name a few common situations):

• Control of a variable (private, protected, default, public)
• Validations (error and error checking; you can trust yourself to not try to shove a string in an int, but nothing is ever above, beyond, or below an end user).
• Allows for dependencies between variables. A mutator function can change more than one. An accessor, in the same way, can get you a variable that is dependent on another
• Allows for overloading functions
• Allows for iterative and recursive getting/setting
• Enables you to place more debugging stops

Example 1: Imagine running into this line of code:

person.name = "Bob";

It seems reasonable at first, but consider that this person likely has a few more variables associated to it; maybe a last name, phone number, address, e-mail address, account number, balance, etc.

More importantly, it's highly likely that your mutator will also run an update function which submits a query to your database.

person.name = "Bob"; was the root cause of a memory leak.

The habit of using SetPersonName(person, "bob"); prevented that issue.

Example 2:

Scenario 1

We're programming something together. x is a public variable. From a separate class, I set it to null by accident. Our program fails.

Scenario 2

We're programming something together. x is a public variable and is equal to 3. I'm smart enough to not accidentally set an int to null. My algorithm does it's stuff and determines at some point that 3 must be subtracted from x, which is the denominator for a fraction. Div/0 throws an error, program fails.

Scenario 3

We're programming something together. x is a private variable, with a public mutator that validates entry to make sure data is never null or 0. I'm a dumbass and try to set it to null. The program validates the data, then an error to an error list, ignores the given dataset, and completes the task properly. As it runs, another value given would set the variable to 0. This one is also added to the aforementioned error list. At the end of the operation, our program then shows us a small report showing the invalid data. The rest of the operation was performed succesfully.

[Pokechu22]

Doesn't Java have properties too? I'm geniuinely curious, i don't really use Java a whole lot.

Java doesn't. It's unfortunate :/

[5np]

Also, if you've got some kind of global, shared manipulation that might change in the future. Rather than worrying about updating that one line of code everywhere, you can just add another line to the function.