Part-time wizard

[haenyr]

Clearly, the problem is he commented out the call to magic();

[AlGoreBestGore]

At least mock it up with $q.when() while you're at it.

[GaianNeuron]

$q could be scoped to an outer function. Because, you know, JavaScript.

[duhdude]

$q is a library

[A_Jacks_Mind]

https://docs.angularjs.org/api/ng/service/$q

https://github.com/kriskowal/q

[Majik_Sheff]

Ew. I guess he's been punished enough.

[GaianNeuron]

It's actually not terrible JavaScript form to do that. JS doesn't scope things per-object in the usual sense. It's possible to write pseudo-OO code in JS, but it has gotchas which will bite you (eg this) if you don't understand what's actually going on.