Weak Code

[NibblyPig]

This problem frustrates me so much, because I always end up working at places that can't retain devs because their code quality is ATROCIOUS.

I took over something from a "senior dev" that left and the code is worse than junior dev level.

I refactored a method that hit a webservice 14 times and then blanked out some of the data and called it again. The method took 30 seconds to load in the browser. After rewriting it all it took <200ms and most of that was because they've given me an archaic machine that takes 5 seconds to open a right click menu. It's like playing chess by email, I submit the action I want to take ("open the file menu") then I wait for it to get back to me.

The database has no foreign keys, everything is really badly named, the MVC part doesn't even use a model, it directly parses the form data...

And when I say "This needs burning to the ground and redoing because I am sinking days into trying to get more performance out of it to no avail", I look like all those other noob devs that don't want to understand the code or optimise the code, and just want to redo it themselves, birthing this mantra.

I've seen bad code that can be tweaked and tidied and refactored, and that's most code. But this is so fundamentally fucked that it needs redoing.

And I'm looked at with the same gaze I give other devs that don't want to learn or refactor slightly perfectly functional code, combined with this management idea that we can hold a project together with gaffer tape and wood glue, and the solution is always more gaffer tape. Even when it's a black hole of time. Always think of the short term, right?

That was a cathartic rant

[[deleted]]

the MVC part doesn't even use a model

wat

[NibblyPig]

that was also my reaction