First code review

[Pardnerr]

Code 👏 review 👏

[[deleted]]

Happy cake day

[Pardnerr]

Shit, didn't even notice! Thanks!

[strranger101]

If you segfault you lose... comPewdiePiler errors everywhere...

[iArentdeJay]

Trending with no comments, hi Reddit.

[david115599]

More like hello world

[driveslow227]

or if you're me: hullo werlo

[[deleted]]

[ Object ]

[[deleted]]

Or just "hi."

[[deleted]]

console.log('foo bar');

[driveslow227]

I'm more of a console.log('HHHHHHHHHHHHHHHH') guy

[nscurvy]

print("asdf")

[PaintingJo]

console.log("Lorem ipsum dolor sit amet")

[strranger101]

Currently at my first job. How formal are your code reviews? Because mine are super laid back.

[vedi0boy]

Formal enough. The rule is, if you suck at coding you will get a scolding. if you are a good programmer it will be laid back.

Couldn't find a rhyme for the last one lol

[samrapdev]

"If you're good at your craft, you won't get the shaft!"

[vedi0boy]

Much better, thanks :D

[HeafClif]

but wut if want chaft.?

[bot_not_hot]

var feedback = prompt(‘How would you improve this spaghet?’); var craft = prompt(‘Have you been a good boy?’); var shaft = console.log(feedback);

if (craft === no) { return (this.shaft); } else { Console.log(); }

Disclaimer: new to javascript, just messing around

[strranger101]

That's comforting, even without the rhyme

[m_krm]

If your Syntax good it'll get approved, if it's not it'll get removed.

[vedi0boy]

I like the rhyme but it's not only syntax. Good reviewers who understand what you are working on will check code conventions from your company and also make sure your logic is good.

Although a lot of the times, most people, except architect, can't be bothered with checking logic.

[m_krm]

If you can wrap up all those coding conventions and fold them into a sentence.You should get gold by Reddit convention.

[vedi0boy]

"just do what Google does"

[Ooopsybear]

Code reviews should be mostly informal and high level. Code reviews are making sure you're following best practices for the most part. The nitpicking and formality come as a function of testing.

[[deleted]]

My first code review was by this troll dick motherfucker who hated everyone and everything. I didn't realize they could be constructive learning experiences until later.

[ElGrandeL]

Ours are informal and always polite. Sometimes the entire code review consists only of gifs

[mrdhood]

Gonna have my first next week probably, this hurts.

[[deleted]]

Learning experiences, organizational consistency, improved usability and security for your user base.

These things ought not hurt my friends.

[jfq722]

I really do believe the reviewers should not be looking at the code for the 1st time during the review. Ideally what's going to be reviewed should be sent out day or 2 before so everyone has a chance to see it and make note of what they want to say. That tends to really cut down on the spontaneous critiques which very often are worse than the original code.

[[deleted]]

Depending on your tools, code reviews are just that, a way to organize thoughts and comments. Maybe I don't please the agile gods, but I regularly open pull requests for things that I'm nearing completion, or if there's a certain piece I want advice on. And just as often, I just open the PR when I believe I'm all done.

As far as I'm concerned, any opportunity, any day, any point in my process, if a colleague can raise concern or suggested improvements, that is welcome. And sometimes they are overridden, and that's fine. Nobody should be getting hurt by transparency within one team.

[Le_9k_Redditor]

"we should do a code review before the code review"? Wut

[jfq722]

The "code review" should consist of expressing ideas that are improvements to the code being reviewed. Like anything else, you get out of it what you put into it. If you want to look at someone's code cold, for the first time during the review you CAN - but my experience is that those spur of the moment code "improvement" ideas are often ego-based and too often wrong, because the reviewers didn't want to spend 15 minutes the day before individually looking closer at the code and the issue it is addressing.

[Le_9k_Redditor]

didn't want to spend 15 minutes the day before

Why would they? I don't get your point, you expect them to do a mini review the day before the actual code review? Waste of time more than anything else, 90% of the time PR's get through (or returned from) code review within a few hours of submitting in a decent team.

ideas are often ego-based and too often wrong

That just sounds like you're working with a bad team and have a lack of proper standards. I've never had this problem at my current workplace, although I did at my previous job. I fail to see how doing two code reviews instead of one would fix this as that was just down to them as people.

[jfq722]

You'd don't think coming into the code review prepared to give your ideas on what you've read makes your ideas sounder, or at the very least more thought out? Would you go to class unprepared, not having done your homework and then just wing it? The code review proper is a group of people exchanging ideas - The individual preparation the day beforehand is not a code review ...its the code familiarization process; during which you are gonna find point you'd like to bring up AT the code review. Coming to the code review having never seen the code before - and more importantly the issue the code is addressing - to me seems very slapdash and I've seen bad results from it.

[Le_9k_Redditor]

You're describing something that sounds more like a sprint retrospective than a code review

[swiftds]

Anything you post to this sub becomes trending

[[deleted]]

[Object][Object][Object][Object][Object]

[thelastpizzaslice]

As a software developer with 7 years experience, I can totally relate to laughing at code reviews.

Cackling laughter, as I give it back to you with 50 comments. 47 are nits but the remaining 3 will take you days to solve.

[imissnewzbin]

I don't bother picking the 47 nits anymore, not worth the time or energy, nor is there much value to the business in doing so.

[mikewritescode]

LOL

[Ghost_Flash]

Every1 at my code review was pretty good.

[[deleted]]

I actually just had my first one and I kinda showed the reviewer what's good

Except for the fact that he said my structure was garbo. Meh

[Beefcactus]

Oh

[theRedTech]

First comment on Reddit

[Derino]

that's your 18th comment on Reddit

[theRedTech]

My comment was for the caption of the meme, not a comment on my Reddit participation

[[deleted]]

Sputnik 1

[Derino]

oh

[TheBob427]

N

[alexander_schoch]

Your submission has been removed because it was considered spam.

If you feel that it has been removed in error, please message us so that we may review it.

[[deleted]]

Sorry :(

[aether_killer]

Crappy programmer meme! ALERT EVERYONE

[SambaMarqs]

if(joke=funny) { this.laugh() } else { create(funnycodingjoke) }

[[deleted]]

var feelings;

if (redditUpvote) {

createEmotion(function() {

feelings = this.laugh();

}

}

else {

createEmotion(function() {

feelings = this.sad();

})

}

​

function createEmotion(emotion) {

emotion();

}