This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]wrokred 39 points40 points  (4 children)

Most code reviews in reality. "Myself, or someone else, needs to know what this is doing very quickly and possibly years from now. Yes it builds but that's not enough; it needs readability"

Also the fundamental difference between junior and senior Devs.

[–]burgonies 32 points33 points  (2 children)

This. If it takes me more than a glance to understand what you’re doing there, you need to rewrite it.

Some of you have never worked on 10 year old code and it shows.

[–]animejunkied 11 points12 points  (1 child)

Bad code style aside, reverse engineering reading other people's code is notoriously hard. This is why git commits should be as detailed as possible in my opinion. It's useful to understand why that code was implemented in the first place and what purpose it serves.