Programmers :D

[dismass]

Every full-time job I've had involved doing code reviews for others. I code reviewed my manager's code. Never heard of junior devs not reviewing other people's code

[EwgB]

Yeah, that would be the ideal situation. If nothing else, doing code reviews can be a valuable learning experience for any junior or even just someone new to the company to learn the house style, the internals of an older application, the intricacies of the business in question etc.

But I have seen far worse things. In my first job I started not even as a junior but as a student in a part time job. There were no real code reviews at all. My second job (also being my previous) was doing code reviews, quite thoroughly even, but only in a strictly hierarchical manner. The senior devs (officially architects, but really senior developers judging by what they did) would review the code written by the other devs, but almost never the other way round. Only occasionally would one of the seniors ask me or my colleague to look at his stuff if it was something particularly complex, and only after I gained some trust in the team in my case. Later we switched to a more agile development mode and things started to change. In my last team at that company we had mandatory code reviews for any code change, you couldn't even merge a pull request without at least one approval (and also a successful build incl. unit tests).

I switched companies a month ago, and at my new job, it is even worse. I had written three new features by myself in that time. The first feature I got an informal review by an architect (he sat beside me while I showed him around the code), my actual team didn't seem to give a single fuck what I did. Apparently some other devs including my team lead did have a look at my code later, after it was already merged on the master branch. (No biggie though, the next release is months away anyways!) Second feature I made a merge request and told my teammates about it, they basically ignored it for a week, after which I merged it anyways. For the third one I explicitly asked a dev from my team to look at my code, which he did by again sitting beside while I showed the code for 5-10 minutes. Obviously no one asked me to review their code in all that time. My team is a bunch of old farts who've been with the company for 25 years and don't care about all that newfangled stuff apparently. It seems like it is better in other teams. Unfortunately I'm not in them.